From patchwork Tue Mar 13 15:43:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 10279619 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3507D6038F for ; Tue, 13 Mar 2018 15:44:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22BBA2621D for ; Tue, 13 Mar 2018 15:44:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 176CE28D01; Tue, 13 Mar 2018 15:44:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC3D52621D for ; Tue, 13 Mar 2018 15:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935066AbeCMPoI (ORCPT ); Tue, 13 Mar 2018 11:44:08 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:36189 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932669AbeCMPnr (ORCPT ); Tue, 13 Mar 2018 11:43:47 -0400 Received: by mail-io0-f196.google.com with SMTP id e30so639273ioc.3 for ; Tue, 13 Mar 2018 08:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=1rYbSct30YcK2iQ5Y4NbRAEta0Qpt5jvdTL9riUMCjI=; b=JnqdJdCPe+gFw0tGuT9PKV2g1UsvY0q0JXOWzvimGbUeQ+UHWdny2bH+LBjJyZl6K7 +Ro/WuLVEB65V+FV0jfdtcyQdb4D8E20oqdtoQ55WRwqS18pd+AAFuUaQD5BXoduAEeS ZaVlwaGAk0UKATr8KgqmckZtoo+9ZvMQC/TOAp5V3Uqn9iz40wBlNejrJb5TjdhcK2Fo vBG6M1comiXXt9kp93qvcwVWmN6f4hHfa9l3dlrkBT//T1Acze+792w5z3wcpRgitFq+ X+NdjtssB12iXqw/7yOOqSTiGrPCYkLTMIDHGXDS4NeTTBbA1cUYtWJFqgRVNEY/hCzn /kxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=1rYbSct30YcK2iQ5Y4NbRAEta0Qpt5jvdTL9riUMCjI=; b=tt5nl762oESQlvK7+5j8jkq5i/Zw4c3xIqls/N6ChG7NjE4whJymjyGbt9suOiDwpK U24pA3hwXBID91/4g81BSmjIpl95uYN/jlzDxXhqkNTjEuG8W/kaoUbP3DdxbBGJr2ry v7Tvqsu/bE4+SCZ4hVL44AhAOCs5C1B0kmYVDpTsEKnFcYkz/Kca58pLIbdgrcxlkmc4 rt4CnwV7urVvbDM4FUaGCecFcuH9Rs1e48cVnlqFOgeV9vRMJ8F7HhoHwgq11J8rx82z acvUOkxT204D/YriqGC6gz6G0+8GcHbf5aRGDPJO0OZntlkRtU2gaD6n/LJeW+KEGkG5 LO7w== X-Gm-Message-State: AElRT7HSu2LJGryYyj0wiqD/V09a3dXdGQbh3zRBn0m4nsA3oikZ4+q0 VPZYIR9AyDLwPeuqa6A4WtQU6w== X-Google-Smtp-Source: AG47ELvC8RP8a11EVKtFd9WSUmFQB7250o40Ktq736LbYuttiaBgvIYm47FAYR6RAatviaou4oC9eg== X-Received: by 10.107.43.7 with SMTP id r7mr1233659ior.302.1520955826575; Tue, 13 Mar 2018 08:43:46 -0700 (PDT) Received: from gateway.1015granger.net (c-68-61-232-219.hsd1.mi.comcast.net. [68.61.232.219]) by smtp.gmail.com with ESMTPSA id i81sm250926itb.21.2018.03.13.08.43.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 08:43:46 -0700 (PDT) Received: from klimt.1015granger.net (klimt.1015granger.net [192.168.1.55]) by gateway.1015granger.net (8.14.7/8.14.7) with ESMTP id w2DFhj5u026269; Tue, 13 Mar 2018 15:43:45 GMT Subject: [PATCH 01/15] sunrpc: Remove unneeded pointer dereference From: Chuck Lever To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org Date: Tue, 13 Mar 2018 11:43:45 -0400 Message-ID: <20180313154345.21531.56695.stgit@klimt.1015granger.net> In-Reply-To: <20180313154053.21531.86316.stgit@klimt.1015granger.net> References: <20180313154053.21531.86316.stgit@klimt.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clean up: Noticed during code inspection that there is already a local automatic variable "xprt" so dereferencing rqst->rq_xprt again is unnecessary. Signed-off-by: Chuck Lever --- net/sunrpc/svc_xprt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index f9307bd..6dca0f5 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c @@ -492,7 +492,7 @@ static void svc_xprt_release(struct svc_rqst *rqstp) { struct svc_xprt *xprt = rqstp->rq_xprt; - rqstp->rq_xprt->xpt_ops->xpo_release_rqst(rqstp); + xprt->xpt_ops->xpo_release_rqst(rqstp); kfree(rqstp->rq_deferred); rqstp->rq_deferred = NULL; @@ -889,7 +889,7 @@ int svc_send(struct svc_rqst *rqstp) goto out; /* release the receive skb before sending the reply */ - rqstp->rq_xprt->xpt_ops->xpo_release_rqst(rqstp); + xprt->xpt_ops->xpo_release_rqst(rqstp); /* calculate over-all length */ xb = &rqstp->rq_res;