[-,alsa-utils,1/1] aplay: Fix wav file not being split on 32 bit platforms
diff mbox

Message ID 20180313185124.5352-1-nebelbank@posteo.de
State New
Headers show

Commit Message

nebelbank@posteo.de March 13, 2018, 6:51 p.m. UTC
On my 32 bit armhf board arecord exits because of write() returning EFBIG
when the output file size reaches 2147483647 bytes.

To fix this, include generated header file before system header files
so that _FILE_OFFSET_BITS=64 is used properly, as required in documentation
"man feature_test_macros".

Signed-off-by: erwin <nebelbank@posteo.de>

Comments

Takashi Iwai March 13, 2018, 6:54 p.m. UTC | #1
On Tue, 13 Mar 2018 19:51:24 +0100,
erwin wrote:
> 
> On my 32 bit armhf board arecord exits because of write() returning EFBIG
> when the output file size reaches 2147483647 bytes.
> 
> To fix this, include generated header file before system header files
> so that _FILE_OFFSET_BITS=64 is used properly, as required in documentation
> "man feature_test_macros".
> 
> Signed-off-by: erwin <nebelbank@posteo.de>

Thanks, the change looks good.  But sign-off is usually with a real
name, otherwise it doesn't make sense from the legal POV (that's the
reason of sign-off, after all).

If you really don't want to expose the name, I can drop it, of
course.  We don't mandate the sign-off in the user-space repos unlike
Linux kernel tree, so far.


Takashi
nebelbank@posteo.de March 13, 2018, 7:27 p.m. UTC | #2
Hello Takashi,

Am 13.03.2018 um 19:54 schrieb Takashi Iwai:
> On Tue, 13 Mar 2018 19:51:24 +0100,
> erwin wrote:
>> [...]
>> Signed-off-by: erwin <nebelbank@posteo.de>
>
> Thanks, the change looks good.  But sign-off is usually with a real
> name, otherwise it doesn't make sense from the legal POV (that's the
> reason of sign-off, after all).

thanks for accepting the patch.

> If you really don't want to expose the name, I can drop it, of
> course.  We don't mandate the sign-off in the user-space repos unlike
> Linux kernel tree, so far.

Yes, I'd rather have it dropped.


Erwin

Patch
diff mbox

diff --git a/aplay/aplay.c b/aplay/aplay.c
index 6b740c2..bbd7fff 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -27,6 +27,7 @@ 
  */
 
 #define _GNU_SOURCE
+#include "aconfig.h"
 #include <stdio.h>
 #include <malloc.h>
 #include <unistd.h>
@@ -49,7 +50,6 @@ 
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <endian.h>
-#include "aconfig.h"
 #include "gettext.h"
 #include "formats.h"
 #include "version.h"