diff mbox

[31/36] drm/i915: Don't fiddle with rps/rc6 across GPU reset

Message ID 20180314093748.8541-31-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson March 14, 2018, 9:37 a.m. UTC
Resetting the GPU doesn't affect the RPS/RC6 state, so we can stop
forcibly reloading the registers.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

sagar.a.kamble@intel.com March 18, 2018, 12:13 p.m. UTC | #1
On 3/14/2018 3:07 PM, Chris Wilson wrote:
> Resetting the GPU doesn't affect the RPS/RC6 state, so we can stop
> forcibly reloading the registers.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Changes look good to me.
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 9f5b3a2a8b61..9443464cebbb 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3162,10 +3162,6 @@ void i915_gem_reset(struct drm_i915_private *dev_priv)
>   	}
>   
>   	i915_gem_restore_fences(dev_priv);
> -
> -	intel_gt_pm_enable_rc6(dev_priv);
> -	if (dev_priv->gt.awake)
> -		intel_gt_pm_busy(dev_priv);
>   }
>   
>   void i915_gem_reset_finish_engine(struct intel_engine_cs *engine)
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9f5b3a2a8b61..9443464cebbb 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3162,10 +3162,6 @@  void i915_gem_reset(struct drm_i915_private *dev_priv)
 	}
 
 	i915_gem_restore_fences(dev_priv);
-
-	intel_gt_pm_enable_rc6(dev_priv);
-	if (dev_priv->gt.awake)
-		intel_gt_pm_busy(dev_priv);
 }
 
 void i915_gem_reset_finish_engine(struct intel_engine_cs *engine)