diff mbox

[03/12] libmultipath: set dm_conf_verbosity

Message ID 1521049605-22050-4-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show

Commit Message

Benjamin Marzinski March 14, 2018, 5:46 p.m. UTC 
dm_conf_verbosity was created to keep dm_write_log from needing
access to the multipath config. However it never was set.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 libmultipath/devmapper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Wilck March 19, 2018, 10:18 a.m. UTC | #1 
On Wed, 2018-03-14 at 12:46 -0500, Benjamin Marzinski wrote:
> dm_conf_verbosity was created to keep dm_write_log from needing
> access to the multipath config. However it never was set.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

I'm curious how much verbosity this will add to multipathd output. But
ut's activated at v >= 4 only, so it should be fine.

Back in my head, I've been thinking about more fine-grained logging
control with log layer + log level for a while...

> ---
>  libmultipath/devmapper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
> index 767d87c..ef1fd2b 100644
> --- a/libmultipath/devmapper.c
> +++ b/libmultipath/devmapper.c
> @@ -95,6 +95,7 @@ dm_write_log (int level, const char *file, int
> line, const char *f, ...)
>  
>  void dm_init(int v)
>  {
> +	dm_conf_verbosity = v;
>  	dm_log_init(&dm_write_log);
>  	dm_log_init_verbose(v + 3);
>  }
diff mbox

Patch

diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 767d87c..ef1fd2b 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -95,6 +95,7 @@  dm_write_log (int level, const char *file, int line, const char *f, ...)
 
 void dm_init(int v)
 {
+	dm_conf_verbosity = v;
 	dm_log_init(&dm_write_log);
 	dm_log_init_verbose(v + 3);
 }