| Message ID | 20180316175354.21437-4-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC > is different from the ones on other Allwinner SoCs. It requires a SRAM > region to be claimed, otherwise all DE2 subblocks won't be accessible. > > Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM > region when probing. Along with this bus driver, we also need drivers/gpu/drm/sun4i/sun4i_drv.c which can usually drive the pipelines like mixer0 and 1 are the cases for A64? Jagan.
On Sat, Apr 14, 2018 at 6:25 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: > On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >> The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC >> is different from the ones on other Allwinner SoCs. It requires a SRAM >> region to be claimed, otherwise all DE2 subblocks won't be accessible. >> >> Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM >> region when probing. > > Along with this bus driver, we also need > drivers/gpu/drm/sun4i/sun4i_drv.c which can usually drive the > pipelines like mixer0 and 1 are the cases for A64? I imagine that's the next part to be sent out, after the hardware representation in the device tree has been decided on. ChenYu
On Sat, Apr 14, 2018 at 4:00 PM, Chen-Yu Tsai <wens@csie.org> wrote: > On Sat, Apr 14, 2018 at 6:25 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: >> On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >>> The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC >>> is different from the ones on other Allwinner SoCs. It requires a SRAM >>> region to be claimed, otherwise all DE2 subblocks won't be accessible. >>> >>> Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM >>> region when probing. >> >> Along with this bus driver, we also need >> drivers/gpu/drm/sun4i/sun4i_drv.c which can usually drive the >> pipelines like mixer0 and 1 are the cases for A64? > > I imagine that's the next part to be sent out, after the hardware > representation in the device tree has been decided on. Yeah, this hardware representation along with separate bus driver going like in another direction especially if we add pipelines support to it, may be we can add sram stuff to platdata of existinf sun4i_drv.c Jagan.
On Sat, Apr 14, 2018 at 4:16 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: > On Sat, Apr 14, 2018 at 4:00 PM, Chen-Yu Tsai <wens@csie.org> wrote: >> On Sat, Apr 14, 2018 at 6:25 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: >>> On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >>>> The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC >>>> is different from the ones on other Allwinner SoCs. It requires a SRAM >>>> region to be claimed, otherwise all DE2 subblocks won't be accessible. >>>> >>>> Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM >>>> region when probing. >>> >>> Along with this bus driver, we also need >>> drivers/gpu/drm/sun4i/sun4i_drv.c which can usually drive the >>> pipelines like mixer0 and 1 are the cases for A64? >> >> I imagine that's the next part to be sent out, after the hardware >> representation in the device tree has been decided on. > > Yeah, this hardware representation along with separate bus driver > going like in another direction especially if we add pipelines support > to it, may be we can add sram stuff to platdata of existinf > sun4i_drv.c Look like SRAM init during sun4i_drv is unable to claim or map the memory? do we have any suggestion on adding 'allwinner,pipelines' ? is it ok to add one more de which is compatible with sun4i_drv.c like this. de: display-engine { compatible = "allwinner,sun8i-a64-display-engine", "allwinner,sun8i-h3-display-engine"; allwinner,pipelines = <&mixer0>; }; Jagan.
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index ff70850031c5..cc8e4b4b6b59 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -95,6 +95,16 @@ config SIMPLE_PM_BUS Controller (BSC, sometimes called "LBSC within Bus Bridge", or "External Bus Interface") as found on several Renesas ARM SoCs. +config SUN50I_DE2_BUS + bool "Allwinner A64 DE2 Bus Driver" + default ARM64 + depends on ARCH_SUNXI + select SUNXI_SRAM + help + Say y here to enable support for Allwinner A64 DE2 bus driver. It's + mostly transparent, but a SRAM region needs to be claimed in the SRAM + controller to make the all blocks in the DE2 part accessible. + config SUNXI_RSB tristate "Allwinner sunXi Reduced Serial Bus Driver" default MACH_SUN8I || MACH_SUN9I || ARM64 diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index 3d473b8adeac..746ff0cebe10 100644 --- a/drivers/bus/Makefile +++ b/drivers/bus/Makefile @@ -19,6 +19,7 @@ obj-$(CONFIG_OMAP_INTERCONNECT) += omap_l3_smx.o omap_l3_noc.o obj-$(CONFIG_OMAP_OCP2SCP) += omap-ocp2scp.o obj-$(CONFIG_QCOM_EBI2) += qcom-ebi2.o +obj-$(CONFIG_SUN50I_DE2_BUS) += sun50i-de2.o obj-$(CONFIG_SUNXI_RSB) += sunxi-rsb.o obj-$(CONFIG_SIMPLE_PM_BUS) += simple-pm-bus.o obj-$(CONFIG_TEGRA_ACONNECT) += tegra-aconnect.o diff --git a/drivers/bus/sun50i-de2.c b/drivers/bus/sun50i-de2.c new file mode 100644 index 000000000000..836828ef96d5 --- /dev/null +++ b/drivers/bus/sun50i-de2.c @@ -0,0 +1,49 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Allwinner A64 Display Engine 2.0 Bus Driver + * + * Copyright (C) 2018 Icenowy Zheng <icenowy@aosc.io> + */ + +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/soc/sunxi/sunxi_sram.h> + +static int sun50i_de2_bus_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + int ret; + + ret = sunxi_sram_claim(&pdev->dev); + if (ret) { + dev_err(&pdev->dev, "Error couldn't map SRAM to device\n"); + return ret; + } + + if (np) + of_platform_populate(np, NULL, NULL, &pdev->dev); + + return 0; +} + +static int sun50i_de2_bus_remove(struct platform_device *pdev) +{ + sunxi_sram_release(&pdev->dev); + return 0; +} + +static const struct of_device_id sun50i_de2_bus_of_match[] = { + { .compatible = "allwinner,sun50i-a64-de2", }, + { /* sentinel */ } +}; + +static struct platform_driver sun50i_de2_bus_driver = { + .probe = sun50i_de2_bus_probe, + .remove = sun50i_de2_bus_remove, + .driver = { + .name = "sun50i-de2-bus", + .of_match_table = sun50i_de2_bus_of_match, + }, +}; + +builtin_platform_driver(sun50i_de2_bus_driver);
The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC is different from the ones on other Allwinner SoCs. It requires a SRAM region to be claimed, otherwise all DE2 subblocks won't be accessible. Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM region when probing. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- drivers/bus/Kconfig | 10 ++++++++++ drivers/bus/Makefile | 1 + drivers/bus/sun50i-de2.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+) create mode 100644 drivers/bus/sun50i-de2.c