soc-core: don't call kfree() for component
diff mbox

Message ID
State New
Headers show

Commit Message

Kuninori Morimoto March 19, 2018, 7:27 a.m. UTC
From: Kuninori Morimoto <>

When driver register its component to ALSA SoC, almost all drivers are
using snd_soc_register_component(), but soc-generic-dmaengine-pcm is
using snd_soc_add_component().

Existing component function had been assumed that registered component
was allocated, and it calling kfree() for it.
But, the user who used snd_soc_add_component() doesn't.

This patch uses devm_kzalloc() instead of kzalloc() for component,
and doesn't call kree() anymore.
This patch fixes commit be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm:
replace platform to component").
Allwinner H3 SoC will crash without this patch.
Thanks Jernej report.

Reported-by: Jernej Skrabec <>
Signed-off-by: Kuninori Morimoto <>
Tested-by: Jernej Skrabec <>
 sound/soc/soc-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff mbox

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index c0edac8..4a8de23 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3476,7 +3476,6 @@  int snd_soc_add_component(struct device *dev,
-	kfree(component);
 	return ret;
@@ -3488,7 +3487,7 @@  int snd_soc_register_component(struct device *dev,
 	struct snd_soc_component *component;
-	component = kzalloc(sizeof(*component), GFP_KERNEL);
+	component = devm_kzalloc(dev, sizeof(*component), GFP_KERNEL);
 	if (!component)
 		return -ENOMEM;
@@ -3523,7 +3522,6 @@  static int __snd_soc_unregister_component(struct device *dev)
 	if (found) {
-		kfree(component);
 	return found;