From patchwork Mon Mar 19 07:27:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10291739 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DC04960349 for ; Mon, 19 Mar 2018 07:27:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0AA828E90 for ; Mon, 19 Mar 2018 07:27:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4F2829163; Mon, 19 Mar 2018 07:27:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 893D428E90 for ; Mon, 19 Mar 2018 07:27:29 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C31972672BA; Mon, 19 Mar 2018 08:27:27 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B180626731A; Mon, 19 Mar 2018 08:27:25 +0100 (CET) Received: from relmlie1.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa0.perex.cz (Postfix) with ESMTP id 4CD73267299 for ; Mon, 19 Mar 2018 08:27:20 +0100 (CET) Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie1.idc.renesas.com with ESMTP; 19 Mar 2018 16:27:18 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id 8A2CE6BAAA; Mon, 19 Mar 2018 16:27:18 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.48,329,1517842800"; d="scan'208";a="274197302" Received: from mail-os2jpn01lp0147.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.147]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Mar 2018 16:27:18 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QSjlgdxFvCNoXVZck9hu82poaxYAABJf2kYFFV0WJ1M=; b=TyQRO6bT75N1699PkM0HJnCntn3bN6ulf34ekriscnjTKocB8ALO54Fpmam/PkMSpg+YouCIbtlKzcxv1an/JrdlEMjgiAdAa+qkJnKMWzzntDbr2xvpFlKYvQZGsDl+1NRlia/dlA/GwFYqDIi7ZeZNZU2vI6yjbgR3QCrMRrA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.138) by TYAPR01MB2080.jpnprd01.prod.outlook.com (2603:1096:404:8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Mon, 19 Mar 2018 07:27:17 +0000 Message-ID: <87efkgttmo.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Mon, 19 Mar 2018 07:27:17 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: KAXPR01CA0002.jpnprd01.prod.outlook.com (2603:1096:402:19::12) To TYAPR01MB2080.jpnprd01.prod.outlook.com (2603:1096:404:8::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 56cb09ca-a2ca-4cb1-c363-08d58d6ad81a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:TYAPR01MB2080; X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2080; 3:vLHaHpl6LyWCj6LeaVUMbq9TNhwCmNYayMQW/5ryhJveGP+o/fypOKz73wr6ShUoSog2YT2z5ZDQoFyhQRnIxQSwO4eLG6iAPVQNNeaRKbr5NMJHzdKv0+NHpsYslk1Ra/BZYwqQqS9m5QbxCOXYFuhN00Goq7wT0rUeKZfbp1/etM4D1SMH7Cfy6226LikcGEuAdew0+x7e0NbLfAi0kPvgUR983LpCcBP4a2uYAii+Vh080P1UiQEwdcGxBVZ6; 25:quw2JVGkkoQPaceDBBwQAx+GFdnJCiAaq2wPBgu7BmWgxk/FHd3yv1TJGqywD81Ad9WtjAYsRrHFOJFu/6i/WIOCku33pbT5qQDHkI2HWK6+eY9pYXpfG+PROO4Rv7uifccAMgZu1EH0ztKUokGGWgvOWnMJYvCi8T/aayX7RVkMwG0vo9+sRVlIxWXPR291XGgxfueK6TJNY2I33s9S31sCnO9W92ABESkgZ3MziUVtWpDXcJayjzyNKPv5ZKzzfiJsnp+71pIHB/0qw6nr0KHZ69O9r/IgCbmCBVEuxVfolEFk6j3f06l8mcPtlWcoLYUvUX/5VjoUZM9xIBedJg==; 31:w09m0K6B0K+Teja3ggMfEAHl+3DP9cnqhlxTadaPmfUqg/NRTmLEwSr/f4Tgc60a3LGMD9NmMCXUghBaf8q7xkgNDU5H/eMUNr13rOpR7AkyPVDwqax4GCNH8PbJjnypMiKI5L52RtFPpimjhZJtQ8isoXgXpViNzdvSFrDT0F2rkjYYYSa0CK/IHFGJ91Y4NXUjoGE8W6D7MHs3Gh+vuLHjPqwWl7B2CFLFyFKAz6s= X-MS-TrafficTypeDiagnostic: TYAPR01MB2080: X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2080; 20:sJq/i/bdphekNx6Jw9cs5Cc/qFNy+FSsfquqJJjpdNOfMAW6glFuB8C4YKQQNguYFmtCluT6b/sJfGk/894bQiHySes3MmuzIOF0y70gzSkOncZ/sgh/3d7i2RkjTxWiZ3zRtaahJV5uACD7WXtQK59eJUNx0zlaV0X7JFA5DS4JJLWo8CLZ4/5uVgfsZTUt3Ynv2Bsz9vbk7go9W1sEQOFKkwLnmC/5g0Adn3DR6sH6Rm4E05rftzcc5+9pAiR+rcOdLJdfYXHBsZV6OefSwPmkfHhsP5ok7ha6pKK1FpVqqZCa8Y7Ro3FOQvBxqQy5ZtQf+O7jvdNKhlzi1j8034kJfRVU9Gjgxd07X5sG0lNhM+dE/7g4J/fx5DqXePyaItN2Ai79aGcMehzekc6EQKtJVmKV+h2bpLZStwWKZU+cjp7DlxPAa46cZvCTdwHqcznCmh+ZMRlRviH4uNA679sUu8DrLfGSEWHGIrlY7/9AFyey+0ocAI3VwnhzRW07; 4:ATSEKA2yW0wLTaE5pFbJFQGzmhpNAs8tuES2ue04MAwsz6v0HVVMI18Jcq0abF3EnCFBrGXFuI+V2KTOpQL/Nkix7fXoMSYfJ4QmM8hPcoRuV8TbxIqe5kYxU+37HRC6lxmpm7jJ3s4ctkziHFd6UPH90RfrWWiS6YqsCM+nZ+umBcorgvOXwQEm1pCT7/JO/TWGEToyyI4kt51BEL4kJOGhLemw/73D82bJCOnNaxrg+u0TRZAV5Uj2sGwWzFkjd5sDX1rn24qfDA3CruutQz0ZZIgUROOgLXJjB0pCLyAw6sp9bdYfhFP2k9RidXUq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501244)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:TYAPR01MB2080; BCL:0; PCL:0; RULEID:; SRVR:TYAPR01MB2080; X-Forefront-PRVS: 06167FAD59 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39380400002)(366004)(39860400002)(376002)(396003)(346002)(199004)(189003)(8676002)(5660300001)(81166006)(81156014)(106356001)(58126008)(23726003)(7696005)(52116002)(69596002)(305945005)(7736002)(6916009)(86362001)(575784001)(6116002)(3846002)(53936002)(68736007)(8936002)(54906003)(2906002)(478600001)(386003)(50466002)(105586002)(26005)(16526019)(25786009)(4326008)(6486002)(316002)(36756003)(97736004)(1857600001)(186003)(53416004)(16586007)(66066001)(47776003)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TYAPR01MB2080; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TYAPR01MB2080; 23:R7ggQOgnk02wQd6+eDxh1nqD2k/e5VkZqrsJZIdQ2?= =?us-ascii?Q?ufNfql7G3EzU1SUzMsnODmQM9DC+UF1d5V+oQDcbIku3LQbpJss4tYPOemBu?= =?us-ascii?Q?eVbUd0iTvc+E6XhrRymeJOmhNO4RabrGlvozIv7bGNI+4SMisYjxPvXP6oWE?= =?us-ascii?Q?AvJV3csV3u9OkSmkGY+iSIHxjggRjzFlNLPql6cF9bspn8UQvcbdJrheEBcO?= =?us-ascii?Q?nMaEeCyvy4izLv94Ud1YIg2+ylSlLTgQJOWiiF+uW7G6C1h6O7IAVCN8MHIK?= =?us-ascii?Q?slQFdgaq9mTj+dRef6mcHSH54dTuuylOe8pdzSmJS5pCgw5a82E5SpUOHCTc?= =?us-ascii?Q?UzQltA3+szIr76ERRVGPFdreBxQLC3KR88u/2rVKdJK+8tYT1s3M19bxyWaq?= =?us-ascii?Q?/+NfHo76qr/igrCcxNXzo3UJCPqEtu3wj4W2FD+Ut/+FipX6gbmPl8mg11nh?= =?us-ascii?Q?nJk1HUTVTNV+uTZYioaIGUqsQzhHTuIYX/YcuND2l2E9HYuk0MPym0her60h?= =?us-ascii?Q?qLufMRAstrsXjRtTAN37D5Ysblpfs3f6enkaw7uQbOXgcJmaxQAKbU+n/ga7?= =?us-ascii?Q?h+4+slPnQqvnb/kAwI0wIODRQ1xpWPNwM2elDeBh7mJewtkE17DAIX03Lvuj?= =?us-ascii?Q?6CHyxtW7Vgmn+Nvb5cuHDepI8ojoMNZQuvg1QbIXstMl2fXslBvnz2+yqpdg?= =?us-ascii?Q?P903Uagq8MqDjr2+o7pgn942/ZrjhPqkWB94dPyE//4XFSiavnWYR9mcwdB/?= =?us-ascii?Q?qxXsnjG1VAUgDA2srACKzleEiGVwMfL9gGqpIXjMz34Kd0KTyMESsvD+ywGN?= =?us-ascii?Q?rgW874XN2tFiaka/SNU2MGicrJQUlFfAIG5S/J4Rp1Ia87Se8isq5LJRqkeZ?= =?us-ascii?Q?eN3bDfpJ0cxdPnyic9R7ZnADzVBpGKEsDDxp3675peqxfN7MsHxHD6jg8Wg1?= =?us-ascii?Q?WJjOECR5QidzvvPcSFfKEPLRCGDTnho/Qr5dxlI1qhE9pMU3l49ZiykeAwQ8?= =?us-ascii?Q?4xKa8XcKpMjLWyckOKthVxKZK02w/9r6P5ZlOGp3eumYlY28YA2rQtpo/8ga?= =?us-ascii?Q?qhatL4ZP4zF9jf449th5UgXpXbDHn5kR+bjT2+3rCSD9gbip1hAMnSn0w9VF?= =?us-ascii?Q?Cse6IpNjwYa0BzfEB8E/cPVHAiw21C1?= X-Microsoft-Antispam-Message-Info: j8XRsMzL1jTTLj7RfjgdF7Mg2fUbfgM9qtdPOAsrPTI8It8HeX6jh+2OqB7R86ew3i56eRS/0iPz6cv3P+hCua7AuGBL7PkD2cU9xmbkSttCYpenGl98VSp6B5gNHj1VWkTXS/uafz+NKw8U7eVRMaJ1ZZCAXSJ+H4MxkeHptWndPoTIHEcYesP2BRL070Me X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2080; 6:8UoBIVFprpKrUkchCvkqJnKFOv6jHUWEpoW0fF1IG+YfsufExauDEwgHpgLXCgW1Tia5C3Uf7ZCEpBt5fLocgZJcs/9tKwI3zQtiiO3Ju60kv7O24gtNxD/Pw/+QfVHiWqc9LGjPXjvYR25eU9FXfZNR7mrHtqm8vAz142GuV5+GEt6wBp71Y2G9Cw7NiSUaaBVgX1m4G6/rwcM0NlifIdJk+1ZVRaBlUr5KuKoxEY/kZcu7xHvrMoWemyr369JxQP7SIO2/2wVorZ8ycHlc67BNfZ1nxS+0PForerrIboZc+xD0vDSJJgd1GxAm4G2XHjDjplPJr0ctJri2qdqx0S4MNqbiyaGwAh60a48Cd1M=; 5:4jxPohoph8VyPxpsstrS8Wgn9lVgeCbrkD3xSQw7UBLUsi4r+SoKWijpLiJK1qXPbYbxnia7pX+hoOfXPeCSaQmxU8/cEi2+Kydeth0us06DwQt8xAKCyQeywaD6mcQMS6dEtdHVLWY0B3cPSZ+iFHYt5dcvSwTw/GbyCwCCUBI=; 24:R5YOilxeuIV6tb2yx8XU895urZDQBl6Sk7n6uxnLi2tpgT5x561A67pI84kFmATjbCfbDbZHv4n0aHZp63RZAGAxGN/mZVU2I6XxY+PZgdI=; 7:SblSenTXziE/SwJbYT2/fnVvPJyYF3S+fc6eSR6GhSgFStNb9xVmP+xBlm657X943wEKary/xw/wzp5eezRr4OhXtSHtnkXMaFU+r0dCI6dZdwPGhmzJqmAXQ+KyDZAPjR5NRGH2+pgNotqtap/Gwh6wmHSQOX4owuwGMu0TUrrVwkvBd1JxtNFREUjc7di/Vg7s+CcKlv8Hi+TdMnjQ60ddztgcKfZh8DOeEcI3VGIy2XH5usHBy1+8kKZC+XYD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2080; 20:nBn7ASOM8b1r5Ac96bQW+Q/a7Z8g2vZE40PzJb5AIjtkdAmKRNJrDWwHPcEGdt9ttZo3MjsZkntdggamX015eDegVKnjec9VboipsLxNwpKggmae3GTW2twB3/yTXCvEIbwsMxywrXFBIxGbCkvpwh6ceC8HIUne3hoZK/x6VBM= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2018 07:27:17.3850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56cb09ca-a2ca-4cb1-c363-08d58d6ad81a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2080 Cc: Linux-ALSA , Jernej Skrabec Subject: [alsa-devel] [PATCH] soc-core: don't call kfree() for component X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto When driver register its component to ALSA SoC, almost all drivers are using snd_soc_register_component(), but soc-generic-dmaengine-pcm is using snd_soc_add_component(). Existing component function had been assumed that registered component was allocated, and it calling kfree() for it. But, the user who used snd_soc_add_component() doesn't. This patch uses devm_kzalloc() instead of kzalloc() for component, and doesn't call kree() anymore. This patch fixes commit be7ee5f32a9a ("ASoC: soc-generic-dmaengine-pcm: replace platform to component"). Allwinner H3 SoC will crash without this patch. Thanks Jernej report. Reported-by: Jernej Skrabec Signed-off-by: Kuninori Morimoto Tested-by: Jernej Skrabec --- sound/soc/soc-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index c0edac8..4a8de23 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3476,7 +3476,6 @@ int snd_soc_add_component(struct device *dev, err_cleanup: snd_soc_component_cleanup(component); err_free: - kfree(component); return ret; } EXPORT_SYMBOL_GPL(snd_soc_add_component); @@ -3488,7 +3487,7 @@ int snd_soc_register_component(struct device *dev, { struct snd_soc_component *component; - component = kzalloc(sizeof(*component), GFP_KERNEL); + component = devm_kzalloc(dev, sizeof(*component), GFP_KERNEL); if (!component) return -ENOMEM; @@ -3523,7 +3522,6 @@ static int __snd_soc_unregister_component(struct device *dev) if (found) { snd_soc_component_cleanup(component); - kfree(component); } return found;