| Message ID | 1521684708-79015-1-git-send-email-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 03/21/2018 09:11 PM, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- Reviewed-by: David Lechner <david@lechnology.com> -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoting Wei Yongjun (2018-03-21 19:11:48) > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- Applied to clk-next -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c index 3b0e59d..ff6f4a0 100644 --- a/drivers/clk/davinci/psc.c +++ b/drivers/clk/davinci/psc.c @@ -521,10 +521,8 @@ static int davinci_psc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } ret = devm_clk_bulk_get(dev, init_data->num_parent_clks, init_data->parent_clks); diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c index 89d30bf..23a24c9 100644 --- a/drivers/clk/davinci/pll.c +++ b/drivers/clk/davinci/pll.c @@ -814,10 +814,8 @@ static int davinci_pll_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } return pll_init(dev, base); }
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/clk/davinci/psc.c | 4 +--- drivers/clk/davinci/pll.c | 4 +--- 2 file changed, 2 insertion(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html