[02/10] kbuild: clean up *.lex.c and *.tab.[ch] patterns from top-level Makefile
diff mbox

Message ID 1521810279-6282-2-git-send-email-yamada.masahiro@socionext.com
State New
Headers show

Commit Message

Masahiro Yamada March 23, 2018, 1:04 p.m. UTC
Files suffixed by .lex.c, .tab.[ch] are generated lexers, parsers,
respectively.  Clean them up globally from the top Makefile.

Some of the final host programs they are linked into are needed for
building external modules, but those intermediates are unneeded.
They can be cleaned away by 'make clean' instead of 'make mrproper'.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 Makefile                  | 1 +
 scripts/dtc/Makefile      | 6 ++----
 scripts/genksyms/Makefile | 2 --
 scripts/kconfig/Makefile  | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

Comments

Frank Rowand March 24, 2018, 1:20 a.m. UTC | #1
On 03/23/18 06:04, Masahiro Yamada wrote:
> Files suffixed by .lex.c, .tab.[ch] are generated lexers, parsers,
> respectively.  Clean them up globally from the top Makefile.
> 
> Some of the final host programs they are linked into are needed for
> building external modules, but those intermediates are unneeded.
> They can be cleaned away by 'make clean' instead of 'make mrproper'.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Frank Rowand <frowand.list@gmail.com>

-Frank

> ---
> 
>  Makefile                  | 1 +
>  scripts/dtc/Makefile      | 6 ++----
>  scripts/genksyms/Makefile | 2 --
>  scripts/kconfig/Makefile  | 2 +-
>  4 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 493e267..168432e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1613,6 +1613,7 @@ clean: $(clean-dirs)
>  		-o -name '*.dwo' -o -name '*.lst' \
>  		-o -name '*.su'  \
>  		-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
> +		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
>  		-o -name '*.symtypes' -o -name 'modules.order' \
>  		-o -name modules.builtin -o -name '.tmp_*.o.*' \
>  		-o -name .cache.mk \
> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> index a88b8c9..d17ba64 100644
> --- a/scripts/dtc/Makefile
> +++ b/scripts/dtc/Makefile
> @@ -28,7 +28,5 @@ HOSTCFLAGS_dtc-parser.tab.o := $(HOSTCFLAGS_DTC)
>  # dependencies on generated files need to be listed explicitly
>  $(obj)/dtc-lexer.lex.o: $(obj)/dtc-parser.tab.h
>  
> -# generated files need to include *.cmd and be cleaned explicitly
> -generated-files	:= dtc-lexer.lex.c dtc-parser.tab.c dtc-parser.tab.h
> -targets		:= $(generated-files)
> -clean-files	:= $(generated-files)
> +# generated files need to include *.cmd
> +targets := dtc-lexer.lex.c dtc-parser.tab.c dtc-parser.tab.h
> diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
> index 34d6ab1..0ccac51 100644
> --- a/scripts/genksyms/Makefile
> +++ b/scripts/genksyms/Makefile
> @@ -11,5 +11,3 @@ HOSTCFLAGS_lex.lex.o := -I$(src)
>  
>  # dependencies on generated files need to be listed explicitly
>  $(obj)/lex.lex.o: $(obj)/parse.tab.h
> -
> -clean-files	:= lex.lex.c parse.tab.c parse.tab.h
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index f9bdd02..1dcd797 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -209,7 +209,7 @@ hostprogs-y := conf nconf mconf kxgettext qconf gconf
>  
>  targets		+= zconf.tab.c zconf.lex.c
>  clean-files	:= qconf.moc .tmp_qtcheck .tmp_gtkcheck
> -clean-files	+= zconf.tab.c zconf.lex.c gconf.glade.h
> +clean-files	+= gconf.glade.h
>  clean-files     += config.pot linux.pot
>  
>  # Check that we have the required ncurses stuff installed for lxdialog (menuconfig)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/Makefile b/Makefile
index 493e267..168432e 100644
--- a/Makefile
+++ b/Makefile
@@ -1613,6 +1613,7 @@  clean: $(clean-dirs)
 		-o -name '*.dwo' -o -name '*.lst' \
 		-o -name '*.su'  \
 		-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
+		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
 		-o -name '*.symtypes' -o -name 'modules.order' \
 		-o -name modules.builtin -o -name '.tmp_*.o.*' \
 		-o -name .cache.mk \
diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index a88b8c9..d17ba64 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -28,7 +28,5 @@  HOSTCFLAGS_dtc-parser.tab.o := $(HOSTCFLAGS_DTC)
 # dependencies on generated files need to be listed explicitly
 $(obj)/dtc-lexer.lex.o: $(obj)/dtc-parser.tab.h
 
-# generated files need to include *.cmd and be cleaned explicitly
-generated-files	:= dtc-lexer.lex.c dtc-parser.tab.c dtc-parser.tab.h
-targets		:= $(generated-files)
-clean-files	:= $(generated-files)
+# generated files need to include *.cmd
+targets := dtc-lexer.lex.c dtc-parser.tab.c dtc-parser.tab.h
diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
index 34d6ab1..0ccac51 100644
--- a/scripts/genksyms/Makefile
+++ b/scripts/genksyms/Makefile
@@ -11,5 +11,3 @@  HOSTCFLAGS_lex.lex.o := -I$(src)
 
 # dependencies on generated files need to be listed explicitly
 $(obj)/lex.lex.o: $(obj)/parse.tab.h
-
-clean-files	:= lex.lex.c parse.tab.c parse.tab.h
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index f9bdd02..1dcd797 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -209,7 +209,7 @@  hostprogs-y := conf nconf mconf kxgettext qconf gconf
 
 targets		+= zconf.tab.c zconf.lex.c
 clean-files	:= qconf.moc .tmp_qtcheck .tmp_gtkcheck
-clean-files	+= zconf.tab.c zconf.lex.c gconf.glade.h
+clean-files	+= gconf.glade.h
 clean-files     += config.pot linux.pot
 
 # Check that we have the required ncurses stuff installed for lxdialog (menuconfig)