| Message ID | 1522187806-17398-1-git-send-email-matthew.s.atwood@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 27 Mar 2018, matthew.s.atwood@intel.com wrote: > From: Matt Atwood <matthew.s.atwood@intel.com> > > As more differentation occurs between DP spec. Its useful to have these > as macros in a drm_dp_helper. > > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com> > --- > drivers/gpu/drm/amd/display/include/dpcd_defs.h | 8 -------- > include/drm/drm_dp_helper.h | 5 +++++ > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/include/dpcd_defs.h b/drivers/gpu/drm/amd/display/include/dpcd_defs.h > index d8e52e3..d13e0f4 100644 > --- a/drivers/gpu/drm/amd/display/include/dpcd_defs.h > +++ b/drivers/gpu/drm/amd/display/include/dpcd_defs.h > @@ -28,14 +28,6 @@ > > #include <drm/drm_dp_helper.h> > > -enum dpcd_revision { > - DPCD_REV_10 = 0x10, > - DPCD_REV_11 = 0x11, > - DPCD_REV_12 = 0x12, > - DPCD_REV_13 = 0x13, > - DPCD_REV_14 = 0x14 > -}; > - > /* these are the types stored at DOWNSTREAMPORT_PRESENT */ > enum dpcd_downstream_port_type { > DOWNSTREAM_DP = 0, > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 4de97e9..f77746e 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -64,6 +64,11 @@ > /* AUX CH addresses */ > /* DPCD */ > #define DP_DPCD_REV 0x000 > +# define DPCD_REV_10 0x10 > +# define DPCD_REV_11 0x11 > +# define DPCD_REV_12 0x12 > +# define DPCD_REV_13 0x13 > +# define DPCD_REV_14 0x14 I'm not really sure what these buy us... but no harm done I guess. Please prefix with DP_ though. BR, Jani. > > #define DP_MAX_LINK_RATE 0x001
diff --git a/drivers/gpu/drm/amd/display/include/dpcd_defs.h b/drivers/gpu/drm/amd/display/include/dpcd_defs.h index d8e52e3..d13e0f4 100644 --- a/drivers/gpu/drm/amd/display/include/dpcd_defs.h +++ b/drivers/gpu/drm/amd/display/include/dpcd_defs.h @@ -28,14 +28,6 @@ #include <drm/drm_dp_helper.h> -enum dpcd_revision { - DPCD_REV_10 = 0x10, - DPCD_REV_11 = 0x11, - DPCD_REV_12 = 0x12, - DPCD_REV_13 = 0x13, - DPCD_REV_14 = 0x14 -}; - /* these are the types stored at DOWNSTREAMPORT_PRESENT */ enum dpcd_downstream_port_type { DOWNSTREAM_DP = 0, diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 4de97e9..f77746e 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -64,6 +64,11 @@ /* AUX CH addresses */ /* DPCD */ #define DP_DPCD_REV 0x000 +# define DPCD_REV_10 0x10 +# define DPCD_REV_11 0x11 +# define DPCD_REV_12 0x12 +# define DPCD_REV_13 0x13 +# define DPCD_REV_14 0x14 #define DP_MAX_LINK_RATE 0x001