Message ID | 20180329153658.11614-2-mdf@kernel.org (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
On Thu, Mar 29, 2018 at 08:36:53AM -0700, Moritz Fischer wrote: > From: Alan Tull <atull@kernel.org> > > Part of patchset that changes the following fpga_*_register > functions to not set drvdata: > * fpga_region_register. > * fpga_mgr_register > * fpga_bridge_register That's not what this specific patch does. Please do not write generic changelog text that is identical for 3 patches that does different things in each one :( thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 29, 2018 at 12:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote: Hi Greg, > On Thu, Mar 29, 2018 at 08:36:53AM -0700, Moritz Fischer wrote: >> From: Alan Tull <atull@kernel.org> >> >> Part of patchset that changes the following fpga_*_register >> functions to not set drvdata: >> * fpga_region_register. >> * fpga_mgr_register >> * fpga_bridge_register > > That's not what this specific patch does. Please do not write generic > changelog text that is identical for 3 patches that does different > things in each one :( Thanks for the guidance, it's always helpful. I'll clean up. Alan > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fpga" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index edab2a2e03ef..ebe1f872810d 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -178,7 +178,6 @@ int fpga_region_register(struct device *dev, struct fpga_region *region) region->dev.parent = dev; region->dev.of_node = dev->of_node; region->dev.id = id; - dev_set_drvdata(dev, region); ret = dev_set_name(®ion->dev, "region%d", id); if (ret) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 119ff75522f1..35e7e8c4a0cb 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -438,6 +438,7 @@ static int of_fpga_region_probe(struct platform_device *pdev) goto eprobe_mgr_put; of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); + dev_set_drvdata(dev, region); dev_info(dev, "FPGA Region probed\n");