diff mbox

btrfs-progs: Remove unused parameter

Message ID 1522378610-21838-1-git-send-email-gujx@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gu Jinxiang March 30, 2018, 2:56 a.m. UTC
Parameter usagestr is not used, remove it.

Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
---
 cmds-filesystem.c | 2 +-
 help.c            | 2 +-
 help.h            | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

Comments

Nikolay Borisov March 30, 2018, 5:49 a.m. UTC | #1
On 30.03.2018 05:56, Gu Jinxiang wrote:
> Parameter usagestr is not used, remove it.
> 
> Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  cmds-filesystem.c | 2 +-
>  help.c            | 2 +-
>  help.h            | 3 +--
>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/cmds-filesystem.c b/cmds-filesystem.c
> index 467aff11..5fa8cf2b 100644
> --- a/cmds-filesystem.c
> +++ b/cmds-filesystem.c
> @@ -1093,7 +1093,7 @@ static int cmd_filesystem_resize(int argc, char **argv)
>  	DIR	*dirstream = NULL;
>  	struct stat st;
>  
> -	clean_args_no_options_relaxed(argc, argv, cmd_filesystem_resize_usage);
> +	clean_args_no_options_relaxed(argc, argv);
>  
>  	if (check_argc_exact(argc - optind, 2))
>  		usage(cmd_filesystem_resize_usage);
> diff --git a/help.c b/help.c
> index 311a4320..f1dd3946 100644
> --- a/help.c
> +++ b/help.c
> @@ -115,7 +115,7 @@ void clean_args_no_options(int argc, char *argv[], const char * const *usagestr)
>   * - "-- option1 option2 ..."
>   * - "option1 option2 ..."
>   */
> -void clean_args_no_options_relaxed(int argc, char *argv[], const char * const *usagestr)
> +void clean_args_no_options_relaxed(int argc, char *argv[])
>  {
>  	if (argc <= 1)
>  		return;
> diff --git a/help.h b/help.h
> index efeded30..a1405942 100644
> --- a/help.h
> +++ b/help.h
> @@ -72,8 +72,7 @@ int check_argc_exact(int nargs, int expected);
>  int check_argc_min(int nargs, int expected);
>  int check_argc_max(int nargs, int expected);
>  void clean_args_no_options(int argc, char *argv[], const char * const *usage);
> -void clean_args_no_options_relaxed(int argc, char *argv[],
> -		const char * const *usagestr);
> +void clean_args_no_options_relaxed(int argc, char *argv[]);
>  
>  void fixup_argv0(char **argv, const char *token);
>  void set_argv0(char **argv);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Sterba March 30, 2018, 5:12 p.m. UTC | #2
On Fri, Mar 30, 2018 at 08:49:55AM +0300, Nikolay Borisov wrote:
> 
> 
> On 30.03.2018 05:56, Gu Jinxiang wrote:
> > Parameter usagestr is not used, remove it.
> > 
> > Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
> 
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 467aff11..5fa8cf2b 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -1093,7 +1093,7 @@  static int cmd_filesystem_resize(int argc, char **argv)
 	DIR	*dirstream = NULL;
 	struct stat st;
 
-	clean_args_no_options_relaxed(argc, argv, cmd_filesystem_resize_usage);
+	clean_args_no_options_relaxed(argc, argv);
 
 	if (check_argc_exact(argc - optind, 2))
 		usage(cmd_filesystem_resize_usage);
diff --git a/help.c b/help.c
index 311a4320..f1dd3946 100644
--- a/help.c
+++ b/help.c
@@ -115,7 +115,7 @@  void clean_args_no_options(int argc, char *argv[], const char * const *usagestr)
  * - "-- option1 option2 ..."
  * - "option1 option2 ..."
  */
-void clean_args_no_options_relaxed(int argc, char *argv[], const char * const *usagestr)
+void clean_args_no_options_relaxed(int argc, char *argv[])
 {
 	if (argc <= 1)
 		return;
diff --git a/help.h b/help.h
index efeded30..a1405942 100644
--- a/help.h
+++ b/help.h
@@ -72,8 +72,7 @@  int check_argc_exact(int nargs, int expected);
 int check_argc_min(int nargs, int expected);
 int check_argc_max(int nargs, int expected);
 void clean_args_no_options(int argc, char *argv[], const char * const *usage);
-void clean_args_no_options_relaxed(int argc, char *argv[],
-		const char * const *usagestr);
+void clean_args_no_options_relaxed(int argc, char *argv[]);
 
 void fixup_argv0(char **argv, const char *token);
 void set_argv0(char **argv);