| Message ID | 1522376717-136486-1-git-send-email-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks for catching that. I'd use -ENODEV to match what is done a few lines below for peer_pdd. With that fixed, this patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> Regards, Felix On 2018-03-29 10:25 PM, Wei Yongjun wrote: > Passing NULL pointer to PTR_ERR will result in return value of 0 > indicating success which is clearly not what it is intended here. > This patch returns -EINVAL instead. > > Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > index cd679cf..c32a341 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > @@ -1421,7 +1421,7 @@ static int kfd_ioctl_unmap_memory_from_gpu(struct file *filep, > > pdd = kfd_get_process_device_data(dev, p); > if (!pdd) { > - err = PTR_ERR(pdd); > + err = -EINVAL; > goto bind_process_to_device_failed; > } >
On Mon, Apr 2, 2018 at 9:02 PM, Felix Kuehling <felix.kuehling@amd.com> wrote: > Thanks for catching that. I'd use -ENODEV to match what is done a few > lines below for peer_pdd. With that fixed, this patch is Reviewed-by: > Felix Kuehling <Felix.Kuehling@amd.com> > > Regards, > Felix > > > On 2018-03-29 10:25 PM, Wei Yongjun wrote: >> Passing NULL pointer to PTR_ERR will result in return value of 0 >> indicating success which is clearly not what it is intended here. >> This patch returns -EINVAL instead. >> >> Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management") >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c >> index cd679cf..c32a341 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c >> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c >> @@ -1421,7 +1421,7 @@ static int kfd_ioctl_unmap_memory_from_gpu(struct file *filep, >> >> pdd = kfd_get_process_device_data(dev, p); >> if (!pdd) { >> - err = PTR_ERR(pdd); >> + err = -EINVAL; >> goto bind_process_to_device_failed; >> } >> > Thanks! Applied to -fixes with the -ENODEV return code Oded
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index cd679cf..c32a341 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -1421,7 +1421,7 @@ static int kfd_ioctl_unmap_memory_from_gpu(struct file *filep, pdd = kfd_get_process_device_data(dev, p); if (!pdd) { - err = PTR_ERR(pdd); + err = -EINVAL; goto bind_process_to_device_failed; }
Passing NULL pointer to PTR_ERR will result in return value of 0 indicating success which is clearly not what it is intended here. This patch returns -EINVAL instead. Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)