Patchwork [v3,1/2] crypto: authenc - don't leak pointers to authenc keys

login
register
mail settings
Submitter Tudor-Dan Ambarus
Date April 3, 2018, 6:39 a.m.
Message ID <20180403063901.5123-1-tudor.ambarus@microchip.com>
Download mbox | patch
Permalink /patch/10320655/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Tudor-Dan Ambarus - April 3, 2018, 6:39 a.m.
In crypto_authenc_setkey we save pointers to the authenc keys in
a local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 crypto/authenc.c | 1 +
 1 file changed, 1 insertion(+)
Herbert Xu - April 20, 2018, 4:50 p.m.
On Tue, Apr 03, 2018 at 09:39:00AM +0300, Tudor Ambarus wrote:
> In crypto_authenc_setkey we save pointers to the authenc keys in
> a local variable of type struct crypto_authenc_keys and we don't
> zeroize it after use. Fix this and don't leak pointers to the
> authenc keys.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Patch applied.  Thanks.

Patch

diff --git a/crypto/authenc.c b/crypto/authenc.c
index d3d6d72..4fa8d40 100644
--- a/crypto/authenc.c
+++ b/crypto/authenc.c
@@ -108,6 +108,7 @@  static int crypto_authenc_setkey(struct crypto_aead *authenc, const u8 *key,
 				       CRYPTO_TFM_RES_MASK);
 
 out:
+	memzero_explicit(&keys, sizeof(keys));
 	return err;
 
 badkey: