diff mbox

WARNING at fs/dcache.c:1500 umount_check+0x5d/0x70

Message ID 201804072112.BJH65604.LQMFtOHOVJFOSF@I-love.SAKURA.ne.jp (mailing list archive)
State New, archived
Headers show

Commit Message

Tetsuo Handa April 7, 2018, 12:12 p.m. UTC
I noticed that SELinux runtime disable causes below messages as of
f605ba97fb805226 ("Merge tag 'vfio-v4.17-rc1' of git://github.com/awilliam/linux-vfio").

[    2.397673] systemd: 28 output lines suppressed due to ratelimiting
[    2.536548] SELinux:  Disabled at runtime.
[    2.556173] audit: type=1404 audit(1523135371.025:2): selinux=0 auid=4294967295 ses=4294967295
[    2.564103] BUG: Dentry 00000000b8066fb4{i=17,n=null}  still in use (1) [unmount of selinuxfs selinuxfs]
[    2.567167] WARNING: CPU: 0 PID: 1 at fs/dcache.c:1500 umount_check+0x5d/0x70
[    2.568057] Modules linked in: sd_mod ata_generic pata_acpi vmwgfx drm_kms_helper ahci syscopyarea libahci mptspi sysfillrect scsi_transport_spi sysimgblt fb_sys_fops ata_piix ttm e1000 mptscsih drm mptbase i2c_core libata serio_raw ipv6
[    2.571083] CPU: 0 PID: 1 Comm: systemd Not tainted 4.16.0+ #351
[    2.571125] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/19/2017
[    2.571166] RIP: 0010:umount_check+0x5d/0x70
[    2.571207] RSP: 0018:ffffc9000064bdc8 EFLAGS: 00010282
[    2.571249] RAX: 000000000000005c RBX: ffff8801389d38a0 RCX: 0000000000000006
[    2.571290] RDX: 0000000000000000 RSI: ffff88013aaf88a8 RDI: ffff88013aaf8000
[    2.571331] RBP: ffff8801389d0000 R08: 0000000000000001 R09: 0000000000000000
[    2.571373] R10: ffffc9000064bd58 R11: 0000000000000000 R12: ffffffff8123a1e0
[    2.571414] R13: ffff8801389d00f0 R14: ffff8801389d38a0 R15: ffff8801389d0080
[    2.571455] FS:  00007fadcda1f940(0000) GS:ffff88013fc00000(0000) knlGS:0000000000000000
[    2.571497] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    2.571538] CR2: 00007ffc62be8f48 CR3: 00000001367c3003 CR4: 00000000001606f0
[    2.571579] Call Trace:
[    2.571621]  d_walk+0x12f/0x500
[    2.571662]  do_one_tree+0x1d/0x30
[    2.571703]  shrink_dcache_for_umount+0x23/0x80
[    2.571745]  generic_shutdown_super+0x15/0x110
[    2.571786]  kill_litter_super+0x1e/0x30
[    2.571827]  deactivate_locked_super+0x34/0x60
[    2.571869]  cleanup_mnt+0x36/0x70
[    2.571910]  task_work_run+0x84/0xa0
[    2.571951]  exit_to_usermode_loop+0x87/0x90
[    2.571993]  do_syscall_64+0x203/0x210
[    2.572034]  entry_SYSCALL_64_after_hwframe+0x42/0xb7
[    2.572075] RIP: 0033:0x7fadcc2583e7
[    2.572117] RSP: 002b:00007ffc62bea7d8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
[    2.572158] RAX: 0000000000000000 RBX: 00007fadcda1f740 RCX: 00007fadcc2583e7
[    2.572199] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000555ed8129770
[    2.572241] RBP: 0000555ed8129980 R08: 00000000ffffffce R09: 000000000000000f
[    2.572282] R10: 00007ffc62bea260 R11: 0000000000000246 R12: 00007ffc62bea83c
[    2.572323] R13: 0000000000000000 R14: 00000000ffffffff R15: 00007ffc62beb358
[    2.572365] Code: 48 8d 88 50 06 00 00 48 8b 40 28 4c 8b 08 48 8b 46 58 48 85 c0 74 19 48 8b 50 40 51 48 c7 c7 48 12 e1 81 48 89 f1 e8 fc b2 e9 ff <0f> 0b 58 eb b1 31 d2 eb e7 66 2e 0f 1f 84 00 00 00 00 00 48 83 
[    2.575111] ---[ end trace c897061d0f839927 ]---
[    2.575269] VFS: Busy inodes after unmount of selinuxfs. Self-destruct in 5 seconds.  Have a nice day...
[    2.599194] systemd[1]: RTC configured in localtime, applying delta of 540 minutes to system time.

Maybe remove %p because %px won't help if self-destructed?
diff mbox

Patch

diff --git a/fs/dcache.c b/fs/dcache.c
index 5930791..f7bbe4c8 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1488,9 +1488,8 @@  static enum d_walk_ret umount_check(void *_data, struct dentry *dentry)
 	if (dentry == _data && dentry->d_lockref.count == 1)
 		return D_WALK_CONTINUE;
 
-	printk(KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
+	printk(KERN_ERR "BUG: Dentry {i=%lx,n=%pd} "
 			" still in use (%d) [unmount of %s %s]\n",
-		       dentry,
 		       dentry->d_inode ?
 		       dentry->d_inode->i_ino : 0UL,
 		       dentry,