Input: alps - Fix reporting pressure of v3 trackstick
diff mbox

Message ID 20180408155321.10433-1-pali.rohar@gmail.com
State Accepted
Headers show

Commit Message

Pali Rohár April 8, 2018, 3:53 p.m. UTC
According to documentation, all 7 lower bits represents trackpoint pressure.

Fixes: 4621c9660459 ("Input: alps - report pressure of v3 and v7 trackstick")
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/input/mouse/alps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov April 23, 2018, 11:26 p.m. UTC | #1
On Sun, Apr 08, 2018 at 05:53:21PM +0200, Pali Rohár wrote:
> According to documentation, all 7 lower bits represents trackpoint pressure.
> 
> Fixes: 4621c9660459 ("Input: alps - report pressure of v3 and v7 trackstick")
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

Applied, thank you.

> ---
>  drivers/input/mouse/alps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 0a9e6a3a2f9f..1e28d9fc5492 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -583,7 +583,7 @@ static void alps_process_trackstick_packet_v3(struct psmouse *psmouse)
>  
>  	x = (s8)(((packet[0] & 0x20) << 2) | (packet[1] & 0x7f));
>  	y = (s8)(((packet[0] & 0x10) << 3) | (packet[2] & 0x7f));
> -	z = packet[4] & 0x7c;
> +	z = packet[4] & 0x7f;
>  
>  	/*
>  	 * The x and y values tend to be quite large, and when used
> -- 
> 2.11.0
>

Patch
diff mbox

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 0a9e6a3a2f9f..1e28d9fc5492 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -583,7 +583,7 @@  static void alps_process_trackstick_packet_v3(struct psmouse *psmouse)
 
 	x = (s8)(((packet[0] & 0x20) << 2) | (packet[1] & 0x7f));
 	y = (s8)(((packet[0] & 0x10) << 3) | (packet[2] & 0x7f));
-	z = packet[4] & 0x7c;
+	z = packet[4] & 0x7f;
 
 	/*
 	 * The x and y values tend to be quite large, and when used