| Message ID | 20180409122332.24788-5-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 4/9/2018 5:53 PM, Michal Wajdeczko wrote: > By calling i915_gem_init_hw in i915_gem_resume and not calling > i915_gem_fini_hw in i915_gem_suspend we introduced asymmetry > in init_hw/fini_hw calls. Let's fix that. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 6f71099..ceec5a0 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -5061,6 +5061,7 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv) > * machines is a good idea, we don't - just in case it leaves the > * machine in an unusable condition. > */ > + i915_gem_fini_hw(dev_priv); > intel_uc_sanitize(dev_priv); > i915_gem_sanitize(dev_priv); >
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 6f71099..ceec5a0 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -5061,6 +5061,7 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv) * machines is a good idea, we don't - just in case it leaves the * machine in an unusable condition. */ + i915_gem_fini_hw(dev_priv); intel_uc_sanitize(dev_priv); i915_gem_sanitize(dev_priv);
By calling i915_gem_init_hw in i915_gem_resume and not calling i915_gem_fini_hw in i915_gem_suspend we introduced asymmetry in init_hw/fini_hw calls. Let's fix that. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_gem.c | 1 + 1 file changed, 1 insertion(+)