[v2] fstests: generic test for fsync after fallocate
diff mbox

Message ID 20180406135915.17619-1-fdmanana@kernel.org
State New
Headers show

Commit Message

Filipe Manana April 6, 2018, 1:59 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Test that fsync operations preserve extents allocated with fallocate(2)
that are placed beyond a file's size.

This test is motivated by a bug found in btrfs where unwritten extents
beyond the inode's i_size were not preserved after a fsync and power
failure. The btrfs bug is fixed by the following patch for the linux

 "Btrfs: fix loss of prealloc extents past i_size after fsync log replay"

Signed-off-by: Filipe Manana <fdmanana@suse.com>

V2: Use different fiemap filter to not relly on written vs unwritten
    differences in extents beyond eof, since has xfs a specific but
    valid behaviour. Also check file sizes after the power failure
    since the new fiemap filter now merges written and unwritten

 tests/generic/482     | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/482.out |  13 ++++++
 tests/generic/group   |   1 +
 3 files changed, 138 insertions(+)
 create mode 100755 tests/generic/482
 create mode 100644 tests/generic/482.out

diff mbox

diff --git a/tests/generic/482 b/tests/generic/482
new file mode 100755
index 00000000..a1947693
--- /dev/null
+++ b/tests/generic/482
@@ -0,0 +1,124 @@ 
+#! /bin/bash
+# FSQA Test No. 482
+# Test that fsync operations preserve extents allocated with fallocate(2) that
+# are placed beyond a file's size.
+# Copyright (C) 2018 SUSE Linux Products GmbH. All Rights Reserved.
+# Author: Filipe Manana <fdmanana@suse.com>
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# GNU General Public License for more details.
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+seq=`basename $0`
+echo "QA output created by $seq"
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+	_cleanup_flakey
+	cd /
+	rm -f $tmp.*
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/dmflakey
+. ./common/punch
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_dm_target flakey
+_require_xfs_io_command "falloc" "-k"
+_require_xfs_io_command "fiemap"
+rm -f $seqres.full
+_scratch_mkfs >>$seqres.full 2>&1
+_require_metadata_journaling $SCRATCH_DEV
+# Create our test files.
+$XFS_IO_PROG -f -c "pwrite -S 0xea 0 256K" $SCRATCH_MNT/foo >/dev/null
+# Create a file with many extents. We later want to shrink truncate it and
+# add a prealloc extent beyond its new size.
+for ((i = 1; i <= 500; i++)); do
+	offset=$(((i - 1) * 4 * 1024))
+	$XFS_IO_PROG -f -s -c "pwrite -S 0xcf $offset 4K" \
+		$SCRATCH_MNT/bar >/dev/null
+# A file which already has a prealloc extent beyond its size.
+# The fsync done on it is motivated by differences in the btrfs implementation
+# of fsync (first fsync has different logic from subsequent fsyncs).
+$XFS_IO_PROG -f -c "pwrite -S 0xf1 0 256K" \
+	     -c "falloc -k 256K 768K" \
+	     -c "fsync" \
+	     $SCRATCH_MNT/baz >/dev/null
+# Make sure everything done so far is durably persisted.
+# Allocate an extent beyond the size of the first test file and fsync it.
+$XFS_IO_PROG -c "falloc -k 256K 1M"\
+	     -c "fsync" \
+	     $SCRATCH_MNT/foo
+# Do a shrinking truncate of our test file, add a prealloc extent to it after
+# its new size and fsync it.
+$XFS_IO_PROG -c "truncate 256K" \
+	     -c "falloc -k 256K 1M"\
+	     -c "fsync" \
+	     $SCRATCH_MNT/bar
+# Allocate another extent beyond the size of file baz.
+$XFS_IO_PROG -c "falloc -k 1M 2M"\
+	     -c "fsync" \
+	     $SCRATCH_MNT/baz
+# Simulate a power failure and mount the filesystem to check that the extents
+# previously allocated were not lost and the file sizes are correct.
+echo "File foo fiemap:"
+$XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/foo | _filter_hole_fiemap
+echo "File foo size:"
+stat --format %s $SCRATCH_MNT/foo
+echo "File bar fiemap:"
+$XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/bar | _filter_hole_fiemap
+echo "File bar size:"
+stat --format %s $SCRATCH_MNT/bar
+echo "File baz fiemap:"
+$XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/baz | _filter_hole_fiemap
+echo "File baz size:"
+stat --format %s $SCRATCH_MNT/baz
diff --git a/tests/generic/482.out b/tests/generic/482.out
new file mode 100644
index 00000000..4848894f
--- /dev/null
+++ b/tests/generic/482.out
@@ -0,0 +1,13 @@ 
+QA output created by 482
+File foo fiemap:
+0: [0..2559]: extent
+File foo size:
+File bar fiemap:
+0: [0..2559]: extent
+File bar size:
+File baz fiemap:
+0: [0..6143]: extent
+File baz size:
diff --git a/tests/generic/group b/tests/generic/group
index e8676062..58ac1f00 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -484,3 +484,4 @@ 
 479 auto quick metadata
 480 auto quick metadata
 481 auto quick log metadata
+482 auto quick log metadata