From patchwork Mon Apr 9 15:45:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Glauber X-Patchwork-Id: 10331709 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A75E26020F for ; Mon, 9 Apr 2018 15:47:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B0C81FFDA for ; Mon, 9 Apr 2018 15:47:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8EA8F287DA; Mon, 9 Apr 2018 15:47:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F1D91FFDA for ; Mon, 9 Apr 2018 15:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbeDIPqo (ORCPT ); Mon, 9 Apr 2018 11:46:44 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34367 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbeDIPqj (ORCPT ); Mon, 9 Apr 2018 11:46:39 -0400 Received: by mail-wm0-f66.google.com with SMTP id w2so18229085wmw.1; Mon, 09 Apr 2018 08:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=08rbDWWf9h4OOHCkIrdknv2sVLk2zeL/mZT/paVPadk=; b=BeSifVX9WljRNsxVUA7duWaxKc0cOSHZFZtB5WulJ3GYLzWdX7oHNgHz2I6Z38oDZh C8VHw/DOgjNksvONUvOfZpvDyaBczcTywm39g41CcjWvULcwvp9Khm7ZALBNU1DH8YY7 RKoWynsNdNONVnq5ezj4mvEmPBCtSZydi69BeUPaPIdUpIDViAHmBzqPIdJwwujy2EzX y/ZeyZE9/o0gEtqyjmiOBN9oKpkKfI+epA/4txV02jLi5WXm4/cvMxXuZ6xjc8dsdhcI Egeil76Tw+Fzj+lM4ODYsFI2hJ7M+5flPAEcwVSDJ5ley6yy4fuhptKEFblyIgECSU/O BvBg== X-Gm-Message-State: ALQs6tADt/o9Z9NfQNhsNH7ZHuatL6t+wwHhiBeTIpoElnu0U+izzg8k 2u+EvLycLElL3KI32+7paYA= X-Google-Smtp-Source: AIpwx4/QYkJcLFxcQ/xKyW23gztK6bmOkfmaTN78ptgrA90FmoKYtdbBDIdFKHXM7lkjdibRojtyFg== X-Received: by 10.28.19.13 with SMTP id 13mr366551wmt.89.1523288798208; Mon, 09 Apr 2018 08:46:38 -0700 (PDT) Received: from wintermute.fritz.box (HSI-KBW-078-043-196-194.hsi4.kabel-badenwuerttemberg.de. [78.43.196.194]) by smtp.gmail.com with ESMTPSA id w40sm881163wrc.33.2018.04.09.08.46.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Apr 2018 08:46:37 -0700 (PDT) From: Jan Glauber To: Herbert Xu Cc: "David S . Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Mahipal Challa , Robert Richter , Jan Glauber Subject: [PATCH v2 3/5] crypto: thunderx_zip: Prevent division by zero Date: Mon, 9 Apr 2018 17:45:52 +0200 Message-Id: <20180409154554.7578-4-jglauber@cavium.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180409154554.7578-1-jglauber@cavium.com> References: <20180409154554.7578-1-jglauber@cavium.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Avoid two potential divisions by zero when calculating average values for the zip statistics. Signed-off-by: Jan Glauber Reviewed-by: Robert Richter --- drivers/crypto/cavium/zip/zip_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cavium/zip/zip_main.c b/drivers/crypto/cavium/zip/zip_main.c index 1cd8aa488185..79b449e0f955 100644 --- a/drivers/crypto/cavium/zip/zip_main.c +++ b/drivers/crypto/cavium/zip/zip_main.c @@ -482,10 +482,11 @@ static int zip_show_stats(struct seq_file *s, void *unused) atomic64_add(val, &st->pending_req); } - avg_chunk = (atomic64_read(&st->comp_in_bytes) / - atomic64_read(&st->comp_req_complete)); - avg_cr = (atomic64_read(&st->comp_in_bytes) / - atomic64_read(&st->comp_out_bytes)); + val = atomic64_read(&st->comp_req_complete); + avg_chunk = (val) ? atomic64_read(&st->comp_in_bytes) / val : 0; + + val = atomic64_read(&st->comp_out_bytes); + avg_cr = (val) ? atomic64_read(&st->comp_in_bytes) / val : 0; seq_printf(s, " ZIP Device %d Stats\n" "-----------------------------------\n" "Comp Req Submitted : \t%lld\n"