ARM: OMAP: n950: set display status to disabled
diff mbox

Message ID 20180418183517.758-1-aaro.koskinen@iki.fi
State New
Headers show

Commit Message

Aaro Koskinen April 18, 2018, 6:35 p.m. UTC
Display is not working on N950 yet, and having it enabled will cause
issues with omapdrm during boot (long delays) and dmesg spam.
Set it to disabled for time being.

Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 arch/arm/boot/dts/omap3-n950.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Tony Lindgren April 18, 2018, 7:21 p.m. UTC | #1
* Aaro Koskinen <aaro.koskinen@iki.fi> [180418 11:37]:
> Display is not working on N950 yet, and having it enabled will cause
> issues with omapdrm during boot (long delays) and dmesg spam.
> Set it to disabled for time being.
> 
> Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

Thanks applying into omap-for-v4.17/fixes.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pavel Machek April 18, 2018, 8:58 p.m. UTC | #2
On Wed 2018-04-18 12:21:39, Tony Lindgren wrote:
> * Aaro Koskinen <aaro.koskinen@iki.fi> [180418 11:37]:
> > Display is not working on N950 yet, and having it enabled will cause
> > issues with omapdrm during boot (long delays) and dmesg spam.
> > Set it to disabled for time being.
> > 
> > Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Acked-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> 
> Thanks applying into omap-for-v4.17/fixes.

I don't think that's good idea.

Hardware works just fine, its just that our drivers are broken. We
should _not_ modify dts. (But we could remove compatible from the
driver, or something...)

									Pavel
Tony Lindgren April 18, 2018, 9:09 p.m. UTC | #3
* Pavel Machek <pavel@ucw.cz> [180418 21:00]:
> On Wed 2018-04-18 12:21:39, Tony Lindgren wrote:
> > * Aaro Koskinen <aaro.koskinen@iki.fi> [180418 11:37]:
> > > Display is not working on N950 yet, and having it enabled will cause
> > > issues with omapdrm during boot (long delays) and dmesg spam.
> > > Set it to disabled for time being.
> > > 
> > > Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > > Acked-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> > 
> > Thanks applying into omap-for-v4.17/fixes.
> 
> I don't think that's good idea.
> 
> Hardware works just fine, its just that our drivers are broken. We
> should _not_ modify dts. (But we could remove compatible from the
> driver, or something...)

Hmm dropping compatible is not going to help with the generic
"panel-dsi-mc" already in various dts files.

I guess you could add some check to the driver based on the
of_machine_is_compatible().

Anyways dropping fix for now pending further discussion.
Tomi, got any ideas?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Aaro Koskinen April 18, 2018, 10:13 p.m. UTC | #4
Hi,

On Wed, Apr 18, 2018 at 10:58:47PM +0200, Pavel Machek wrote:
> On Wed 2018-04-18 12:21:39, Tony Lindgren wrote:
> > * Aaro Koskinen <aaro.koskinen@iki.fi> [180418 11:37]:
> > > Display is not working on N950 yet, and having it enabled will cause
> > > issues with omapdrm during boot (long delays) and dmesg spam.
> > > Set it to disabled for time being.
> > > 
> > > Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > > Acked-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> > 
> > Thanks applying into omap-for-v4.17/fixes.
> 
> I don't think that's good idea.
> 
> Hardware works just fine, its just that our drivers are broken. We
> should _not_ modify dts. (But we could remove compatible from the
> driver, or something...)

Please send a patch to fix the regression.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts
index 2354e09343f3..aa757482d572 100644
--- a/arch/arm/boot/dts/omap3-n950.dts
+++ b/arch/arm/boot/dts/omap3-n950.dts
@@ -231,6 +231,7 @@ 
 	lcd0: display {
 		compatible = "nokia,himalaya", "panel-dsi-cm";
 		label = "lcd0";
+		status = "disabled";
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&display_pins>;