| Message ID | 20180424025659.23659-1-dhinakaran.pandiyan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday, April 23, 2018 8:25:02 PM PDT Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915/dp: Check if the sink crc we > read is 6 bytes. URL : https://patchwork.freedesktop.org/series/42154/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4082 -> Patchwork_8783 = > > == Summary - FAILURE == > > Serious unknown changes coming with Patchwork_8783 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_8783, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in > CI. > > External URL: > https://patchwork.freedesktop.org/api/1.0/series/42154/revisions/1/mbox/ > > == Possible new issues == > > Here are the unknown changes that may have been introduced in > Patchwork_8783: > > === IGT changes === > > ==== Possible regressions ==== > > igt@kms_frontbuffer_tracking@basic: > fi-cnl-y3: PASS -> FAIL > fi-cnl-psr: PASS -> FAIL > fi-cfl-s3: PASS -> FAIL > {fi-kbl-7560u}: PASS -> FAIL > fi-skl-6600u: PASS -> FAIL > fi-kbl-r: PASS -> FAIL > fi-cfl-u: PASS -> FAIL > These failures are expected, tests need to modified if this series is accepted. > > ==== Warnings ==== > > igt@kms_force_connector_basic@force-load-detect: > fi-ivb-3520m: PASS -> SKIP +3 > > igt@kms_sink_crc_basic: > fi-cfl-u: PASS -> SKIP > fi-cnl-psr: PASS -> SKIP > So are these. > > == Known issues == > > Here are the changes found in Patchwork_8783 that come from known issues: > > === IGT changes === > > ==== Issues hit ==== > > igt@gem_mmap_gtt@basic-small-bo-tiledx: > fi-gdg-551: PASS -> FAIL (fdo#102575) > > igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence: > fi-skl-guc: PASS -> FAIL (fdo#103191) > > > ==== Possible fixes ==== > > igt@gem_exec_suspend@basic-s4-devices: > fi-ilk-650: DMESG-WARN -> PASS > > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: > fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS > > igt@prime_vgem@basic-fence-flip: > fi-ilk-650: FAIL (fdo#104008) -> PASS > > > {name}: This element is suppressed. This means it is ignored when > computing the status of the difference (SUCCESS, WARNING, or FAILURE). > > fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575 > fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 > fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 > fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008 > > > == Participating hosts (36 -> 33) == > > Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq > > > == Build changes == > > * Linux: CI_DRM_4082 -> Patchwork_8783 > > CI_DRM_4082: 0600266ef9b8407e0dc281acb6b754eba8178c91 @ > git://anongit.freedesktop.org/gfx-ci/linux IGT_4444: > dcc44347494231feabc588c2a76998cbc9afdf8c @ > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_8783: > c0e07f8b9d9412e9d41da72654ec408658913b94 @ > git://anongit.freedesktop.org/gfx-ci/linux piglit_4444: > a2f486679f467cd6e82578384f56d4aabaa8cf2e @ > git://anongit.freedesktop.org/piglit > > > == Linux commits == > > c0e07f8b9d94 drm/i915/psr: Move sink-crc to intel_psr.c > 676d279f8a86 drm/i915/dp: Fix sink-crc reads. > 7fc2b33053e5 drm/i915/dp: Check if the sink crc we read is 6 bytes. > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8783/issues.html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Apr 23, 2018 at 07:56:57PM -0700, Dhinakaran Pandiyan wrote: > We attempt to read 6 bytes, make sure we have. > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 62f82c4298ac..7dcc874b7d8f 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3989,7 +3989,7 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, struct intel_crtc_state *crtc_s > goto stop; > } > > - if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) { > + if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) != 6) { > ret = -EIO; > goto stop; > } > -- > 2.14.1 >
On Wed, Apr 25, 2018 at 10:48:10PM -0000, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915/dp: Check if the sink crc we read is 6 bytes. (rev3) > URL : https://patchwork.freedesktop.org/series/42154/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4099 -> Patchwork_8804 = > > == Summary - FAILURE == > > Serious unknown changes coming with Patchwork_8804 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_8804, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/42154/revisions/3/mbox/ > > == Possible new issues == > > Here are the unknown changes that may have been introduced in Patchwork_8804: > > === IGT changes === > > ==== Possible regressions ==== > > igt@kms_frontbuffer_tracking@basic: > fi-cnl-y3: PASS -> FAIL > fi-cnl-psr: PASS -> FAIL > fi-cfl-s3: PASS -> FAIL > fi-kbl-7560u: PASS -> FAIL > fi-skl-6600u: PASS -> FAIL > {fi-hsw-4200u}: PASS -> FAIL > fi-kbl-r: PASS -> FAIL > fi-cfl-u: PASS -> FAIL it seems that we need to kill sink_crc test case first... > > > ==== Warnings ==== > > igt@kms_sink_crc_basic: > fi-cfl-u: PASS -> SKIP > {fi-hsw-4200u}: PASS -> SKIP > fi-cnl-psr: PASS -> SKIP > > > == Known issues == > > Here are the changes found in Patchwork_8804 that come from known issues: > > === IGT changes === > > ==== Possible fixes ==== > > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: > fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 > > > == Participating hosts (38 -> 35) == > > Missing (3): fi-ilk-m540 fi-skl-6700hq fi-pnv-d510 > > > == Build changes == > > * Linux: CI_DRM_4099 -> Patchwork_8804 > > CI_DRM_4099: 92a39635c2eca4dfe1c8c1673e0c606a720746e5 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4449: 0350f0e7f6a0e07281445fc3082aa70419f4aac7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_8804: 3288f3762198964ac51b630273a5b3cbbee2db4d @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4449: ad8992d3fb27fd604b9ab15e7963c42421ced85c @ git://anongit.freedesktop.org/piglit > > > == Linux commits == > > 3288f3762198 drm/i915/psr: Move sink-crc to intel_psr.c > d8db909cc13f drm/i915/dp: Fix sink-crc reads. > 89124b64449f drm/i915/dp: Check if the sink crc we read is 6 bytes. > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8804/issues.html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 62f82c4298ac..7dcc874b7d8f 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3989,7 +3989,7 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, struct intel_crtc_state *crtc_s goto stop; } - if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) { + if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) != 6) { ret = -EIO; goto stop; }
We attempt to read 6 bytes, make sure we have. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)