From patchwork Tue Apr 24 06:08:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sebastian Gottschall X-Patchwork-Id: 10358681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 07C2460225 for ; Tue, 24 Apr 2018 06:08:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC65228B8C for ; Tue, 24 Apr 2018 06:08:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E108B28BDA; Tue, 24 Apr 2018 06:08:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3347528B8C for ; Tue, 24 Apr 2018 06:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nU42cJdfdsCB516MP1I35U5R+o9NZVFKuZdszUJrpFc=; b=n743Yvuf6zZ6Cn5BOwCf7uqEA d6N06/DSNp81/eWsWBf71VO8M2Fd8JewA6U2pepcY6iPCFPKbTaJe1Zt1n1NQdpTjIBXGSiTLgdcC 1MiC32K9lqfSJZYjvmOcZPPbSjYCAieLdTfHfgxknh0UkLIXteCePMwPRywRPsjsjy3h8o872FCY/ RC0x5zs9M99CUy+NSpW5BL/HPKM1gmyVCNbZtg6H/enZuRwVkCcwRJ9zaiUuk+YSJMY7rrD4WQ8wP Mmx0HHAyIyltQIdcuYTuCAGd9rQvcK7LK+xe8HINo+e0+ce67erMtKh/LD6K3kXMJpEg31XZFEmQ0 HsktBdLww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAr7p-00041b-Bn; Tue, 24 Apr 2018 06:08:25 +0000 Received: from smtps.newmedia-net.de ([2a05:a1c0:0:de::167] helo=webmail.newmedia-net.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAr7m-00040n-66 for ath10k@lists.infradead.org; Tue, 24 Apr 2018 06:08:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/xAk1K66krwQg5FJRLbW7hQLz1BL4Pjyi3ZnuI8ediA=; b=DhUh9otojPhDHSNVQnhELDGDhZPiGkFnO3QQkpprxR8qYvT0Ygntb/zplzameV7OE/Dd6SxcCrDSNtxHhTWiH+u/eVjxbtC3C6ImmAN+k82Bo0ZzOD8WVP47+qyeGL0bS+zgGGY62j6Yg4+jfZtmRa5DWybTb5EvbJfzwjaULYg=; Subject: Re: 9984 with 10.4.3.5.3-0057 crashes To: Kalle Valo References: <1523966821-21903-1-git-send-email-pillair@codeaurora.org> <1523966821-21903-5-git-send-email-pillair@codeaurora.org> <946e582c-2438-872b-eec8-25d9dcb994d9@dd-wrt.com> <7a06a34a5fcb97e07a8d79b4d689e781@codeaurora.org> <87604oodt4.fsf@kamboji.qca.qualcomm.com> <8736zrjgq6.fsf@kamboji.qca.qualcomm.com> <5AD9A1DF.6060007@broadcom.com> <87wowxdirv.fsf@kamboji.qca.qualcomm.com> <87k1sxcgyh.fsf@kamboji.qca.qualcomm.com> From: Sebastian Gottschall Message-ID: Date: Tue, 24 Apr 2018 08:08:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87k1sxcgyh.fsf@kamboji.qca.qualcomm.com> X-Received: from [2003:c9:3f40:cb00:1f8:13ec:c72d:150b] by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1fAr7Z-0000DD-2u; Tue, 24 Apr 2018 08:08:09 +0200 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180423_230822_550938_7BB1E1CF X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ath10k@lists.infradead.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Am 24.04.2018 um 07:27 schrieb Kalle Valo: > Sebastian Gottschall writes: > >> just for your notice. 10.4.3.5.3-0057 on 9984 which was just released >> crashes in vht160 operation mode immediatly after first station >> associates >> last known working stable fw so far is 10.4-3.4-00104. the whole >> 10.4.3.5.3 series seem to be seriously broken or the api has been >> changed in a way >> which is unsupported by ath10k (which i think is the cause of the >> problem) >> it would be good to know what has been changed. > At least I was not informed any changes in the firmware interface. What > version of ath10k are you using? Do you have any custom patches on > ath10k? i'm using latest git version for testing here but there is one relevant patch required for more recent firmwares like 3.4 series (see below) i posted already a long time ago, that vht160 will not work anymore without that patch in newer firmwares since qca changed the api for channel mapping in vht160. (i took this information from the propertiery qca driver sourcecodes) see our discussion on 2.feb 2017 about that required change. it seems that you lost the path on that issue. as far as i know this change was required because of compatiblity issues with vht80 clients from some other vendors. i have seen similar changes in hostapd for mwlwifi driver +       }         ch->min_power = arg->min_power;         ch->max_power = arg->max_power;         ch->reg_power = arg->max_reg_power; > --- wmi.c.old   2018-02-16 11:25:13.023117123 +0100 +++ wmi.c       2018-04-24 07:47:12.642395002 +0200 @@ -1661,13 +1661,18 @@ void ath10k_wmi_put_wmi_channel(struct w                 flags |= WMI_CHAN_FLAG_HT40_PLUS;         if (arg->chan_radar)                 flags |= WMI_CHAN_FLAG_DFS; - +       ch->band_center_freq2 = 0;         ch->mhz = __cpu_to_le32(arg->freq);         ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1);         if (arg->mode == MODE_11AC_VHT80_80)                 ch->band_center_freq2 = __cpu_to_le32(arg->band_center_freq2); -       else -               ch->band_center_freq2 = 0; +       if (arg->mode == MODE_11AC_VHT160)  { +               if (arg->freq < arg->band_center_freq1) +                       ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 - 40); +               else +                       ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 + 40); +               ch->band_center_freq2 = __cpu_to_le32(arg->band_center_freq1);