diff mbox

drm: mali-dp: Enable Global SE interrupts mask for DP500

Message ID 20180424024232.37687-1-alison.wang@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alison Wang April 24, 2018, 2:42 a.m. UTC 
In the situation that DE and SE aren’t shared the same interrupt number,
the Global SE interrupts mask bit MASK_IRQ_EN in MASKIRQ must be set, or
else other mask bits will not work and no SE interrupt will occur. This
patch enables MASK_IRQ_EN for SE to fix this problem.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
---
 drivers/gpu/drm/arm/malidp_hw.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Liviu Dudau April 24, 2018, 9:08 a.m. UTC | #1 
On Tue, Apr 24, 2018 at 10:42:32AM +0800, Alison Wang wrote:
> In the situation that DE and SE aren’t shared the same interrupt number,
> the Global SE interrupts mask bit MASK_IRQ_EN in MASKIRQ must be set, or
> else other mask bits will not work and no SE interrupt will occur. This
> patch enables MASK_IRQ_EN for SE to fix this problem.
> 
> Signed-off-by: Alison Wang <alison.wang@nxp.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Thanks for catching this! I'll pull the patch into the mali-dp tree.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_hw.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
> index d789b46..069783e 100644
> --- a/drivers/gpu/drm/arm/malidp_hw.c
> +++ b/drivers/gpu/drm/arm/malidp_hw.c
> @@ -634,7 +634,8 @@ static int malidp650_query_hw(struct malidp_hw_device *hwdev)
>  				.vsync_irq = MALIDP500_DE_IRQ_VSYNC,
>  			},
>  			.se_irq_map = {
> -				.irq_mask = MALIDP500_SE_IRQ_CONF_MODE,
> +				.irq_mask = MALIDP500_SE_IRQ_CONF_MODE |
> +					    MALIDP500_SE_IRQ_GLOBAL,
>  				.vsync_irq = 0,
>  			},
>  			.dc_irq_map = {
> -- 
> 1.7.1
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
index d789b46..069783e 100644
--- a/drivers/gpu/drm/arm/malidp_hw.c
+++ b/drivers/gpu/drm/arm/malidp_hw.c
@@ -634,7 +634,8 @@  static int malidp650_query_hw(struct malidp_hw_device *hwdev)
 				.vsync_irq = MALIDP500_DE_IRQ_VSYNC,
 			},
 			.se_irq_map = {
-				.irq_mask = MALIDP500_SE_IRQ_CONF_MODE,
+				.irq_mask = MALIDP500_SE_IRQ_CONF_MODE |
+					    MALIDP500_SE_IRQ_GLOBAL,
 				.vsync_irq = 0,
 			},
 			.dc_irq_map = {