| Message ID | 1312473569-1212-1-git-send-email-abhilash.kv@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Abhilash K V <abhilash.kv@ti.com> writes: > From: Vaibhav Hiremath <hvaibhav@ti.com> > > In case of AM3517 & AM3505, Smart Reflex is not applicable so > we must not enable it. So add check for am3517/05 cpu revision > in omap3_twl_init() and return -ENODEV if true, else continue. > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > Signed-off-by: Abhilash K V <abhilash.kv@ti.com> > --- > arch/arm/mach-omap2/omap_twl.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c > index 07d6140..92fadcb 100644 > --- a/arch/arm/mach-omap2/omap_twl.c > +++ b/arch/arm/mach-omap2/omap_twl.c > @@ -269,6 +269,14 @@ int __init omap3_twl_init(void) > if (!cpu_is_omap34xx()) > return -ENODEV; > > + /* > + * In case of AM3517/AM3505 we should not be going down > + * further, since SR is not applicable there. > + */ > + if (cpu_is_omap3505() || cpu_is_omap3517()) { > + return -ENODEV; > + } > + Rather than using cpu_is_*, you should add a new "feature" flag for SmartReflex. We already have this for things like SGX, IVA, NEON, etc. See <plat/feature.h> Kevin > if (cpu_is_omap3630()) { > omap3_mpu_volt_info.vp_vddmin = OMAP3630_VP1_VLIMITTO_VDDMIN; > omap3_mpu_volt_info.vp_vddmax = OMAP3630_VP1_VLIMITTO_VDDMAX;
Kevin Hilman wrote: >Abhilash K V <abhilash.kv@ti.com> writes: > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > In case of AM3517 & AM3505, Smart Reflex is not applicable so > > we must not enable it. So add check for am3517/05 cpu revision > > in omap3_twl_init() and return -ENODEV if true, else continue. > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > Signed-off-by: Abhilash K V <abhilash.kv@ti.com> > > --- > > arch/arm/mach-omap2/omap_twl.c | 8 ++++++++ > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/omap_twl.c > b/arch/arm/mach-omap2/omap_twl.c > > index 07d6140..92fadcb 100644 > > --- a/arch/arm/mach-omap2/omap_twl.c > > +++ b/arch/arm/mach-omap2/omap_twl.c > > @@ -269,6 +269,14 @@ int __init omap3_twl_init(void) > > if (!cpu_is_omap34xx()) > > return -ENODEV; > > > > + /* > > + * In case of AM3517/AM3505 we should not be going down > > + * further, since SR is not applicable there. > > + */ > > + if (cpu_is_omap3505() || cpu_is_omap3517()) { > > + return -ENODEV; > > + } > > + > > Rather than using cpu_is_*, you should add a new "feature" flag for > SmartReflex. We already have this for things like SGX, IVA, NEON, etc. > See <plat/feature.h> I did not find a feature.h; did you mean OMAP3_CHECK_FEATURE macro which is used by omap3_check_features(), which gleans for presence of L2CACHE, IVA, SGX, NEON, ISP features from the Control Device Status Register (0x4800 244C) ? There is no such bit-field to indicate the presence of smart-reflex feature in this register. AFAIK, there is no such global register as well which could indicate this. - Abhilash > Kevin > > > > if (cpu_is_omap3630()) { > > omap3_mpu_volt_info.vp_vddmin = > OMAP3630_VP1_VLIMITTO_VDDMIN; > > omap3_mpu_volt_info.vp_vddmax = > OMAP3630_VP1_VLIMITTO_VDDMAX; > >
"Koyamangalath, Abhilash" <abhilash.kv@ti.com> writes: > Kevin Hilman wrote: >>Abhilash K V <abhilash.kv@ti.com> writes: >> >> > From: Vaibhav Hiremath <hvaibhav@ti.com> >> > >> > In case of AM3517 & AM3505, Smart Reflex is not applicable so >> > we must not enable it. So add check for am3517/05 cpu revision >> > in omap3_twl_init() and return -ENODEV if true, else continue. >> > >> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> >> > Signed-off-by: Abhilash K V <abhilash.kv@ti.com> >> > --- >> > arch/arm/mach-omap2/omap_twl.c | 8 ++++++++ >> > 1 files changed, 8 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap2/omap_twl.c >> b/arch/arm/mach-omap2/omap_twl.c >> > index 07d6140..92fadcb 100644 >> > --- a/arch/arm/mach-omap2/omap_twl.c >> > +++ b/arch/arm/mach-omap2/omap_twl.c >> > @@ -269,6 +269,14 @@ int __init omap3_twl_init(void) >> > if (!cpu_is_omap34xx()) >> > return -ENODEV; >> > >> > + /* >> > + * In case of AM3517/AM3505 we should not be going down >> > + * further, since SR is not applicable there. >> > + */ >> > + if (cpu_is_omap3505() || cpu_is_omap3517()) { >> > + return -ENODEV; >> > + } >> > + >> >> Rather than using cpu_is_*, you should add a new "feature" flag for >> SmartReflex. We already have this for things like SGX, IVA, NEON, etc. >> See <plat/feature.h> > I did not find a feature.h; sorry, I meant <plat/cpu.yh> > did you mean OMAP3_CHECK_FEATURE macro which is used by > omap3_check_features(), which gleans for presence of L2CACHE, IVA, SGX, NEON, ISP features > from the Control Device Status Register (0x4800 244C) ? yes, OMAP3_HAS_FEATURE() > There is no such bit-field to indicate the presence of smart-reflex feature in this register. > AFAIK, there is no such global register as well which could indicate this. There doesn't have to be a register read to indicate this. See for example the HAS_IO_WAKEUP feature. Kevin > - Abhilash > >> Kevin >> >> >> > if (cpu_is_omap3630()) { >> > omap3_mpu_volt_info.vp_vddmin = >> OMAP3630_VP1_VLIMITTO_VDDMIN; >> > omap3_mpu_volt_info.vp_vddmax = >> OMAP3630_VP1_VLIMITTO_VDDMAX; >> >>
diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c index 07d6140..92fadcb 100644 --- a/arch/arm/mach-omap2/omap_twl.c +++ b/arch/arm/mach-omap2/omap_twl.c @@ -269,6 +269,14 @@ int __init omap3_twl_init(void) if (!cpu_is_omap34xx()) return -ENODEV; + /* + * In case of AM3517/AM3505 we should not be going down + * further, since SR is not applicable there. + */ + if (cpu_is_omap3505() || cpu_is_omap3517()) { + return -ENODEV; + } + if (cpu_is_omap3630()) { omap3_mpu_volt_info.vp_vddmin = OMAP3630_VP1_VLIMITTO_VDDMIN; omap3_mpu_volt_info.vp_vddmax = OMAP3630_VP1_VLIMITTO_VDDMAX;