Patches: fix non-standard getaddrinfo usage, minor fixups (fix w/musl)
diff mbox

Message ID CAKGWAO_DsJWLeKCrDytXLGUM-Je+P6T6d9z8P=tV_PCgJAYxzw@mail.gmail.com
State New
Headers show

Commit Message

Will Dietz April 29, 2018, 11:16 p.m. UTC
The getaddrinfo problem needs a proper fix and probably a
consideration of similar patterns elsewhere in the code.

The others are relatively straightforward and are more suitable for use as-is.

A fix not included would be to avoid using "-Werror" except when
developing-- or at least make its use optional.  Without knowledge of
the compilers used by downstream, this option may cause builds to fail
for unimportant reasons (and even if it works with all compilers
today, it might not tomorrow...).   Would be nice to have that in
before the next tagged release :).  GCC 7.3.0 seems to be unhappy with
some prototypes for example, I don't have them handy but can send them
along if that'd be useful.

Thanks! LMK if you have any questions or concerns, hopefully these are helpful.

~Will

Comments

Steve Dickson May 1, 2018, 2:22 p.m. UTC | #1
On 04/29/2018 07:16 PM, Will Dietz wrote:
> The getaddrinfo problem needs a proper fix and probably a
> consideration of similar patterns elsewhere in the code.
> 
> The others are relatively straightforward and are more suitable for use as-is.
> 
> A fix not included would be to avoid using "-Werror" except when
> developing-- or at least make its use optional.  Without knowledge of
> the compilers used by downstream, this option may cause builds to fail
> for unimportant reasons (and even if it works with all compilers
> today, it might not tomorrow...).   Would be nice to have that in
> before the next tagged release :).  GCC 7.3.0 seems to be unhappy with
> some prototypes for example, I don't have them handy but can send them
> along if that'd be useful.
> 
> Thanks! LMK if you have any questions or concerns, hopefully these are helpful.
Having the patch attached like this makes it very different to review 
and comment on... It much better when patches are posted in a thread. 

Could you please repost these patch in a thread format...
Here is the command I use:

DRYRUN=--dry-run
DIR=/tmp
git send-email $DRYRUN  --suppress-cc=all --suppress-from --no-chain-reply-to \
   --from "My Name <myname@domain.com>" \
   --to "Linux NFS Mailing list <linux-nfs@vger.kernel.org>" \
   --smtp-server smtp.com $DIR/*.patch

tia,

steved
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

From 665a0e665a0e526a5d4021de28c3a3613cbe02db Mon Sep 17 00:00:00 2001
From: Will Dietz <w@wdtz.org>
Date: Sun, 29 Apr 2018 16:21:56 -0500
Subject: [PATCH 6/6] configure.ac: check for res_querydomain instead of
 __res_querydomain

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 5a11636..8d5d9a1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -408,7 +408,7 @@  if test "$enable_gss" = yes; then
 fi
 
 dnl libdnsidmap specific checks
-AC_CHECK_LIB([resolv], [__res_querydomain], , AC_MSG_ERROR(res_querydomain needed))
+AC_CHECK_LIB([resolv], [res_querydomain], , AC_MSG_ERROR(res_querydomain needed))
 
 AC_ARG_ENABLE([ldap],
 	[AS_HELP_STRING([--disable-ldap],[Disable support for LDAP @<:default=detect@:>@])])
-- 
2.17.0