ARM: dts: logicpd-som-lv: Fix pinmux controller references
diff mbox

Message ID 20180430174748.11074-1-aford173@gmail.com
State New
Headers show

Commit Message

Adam Ford April 30, 2018, 5:47 p.m. UTC
The pinmux controllers do not themselves need references to
'pinctrl-names' or 'pinctrl-0'

This patch removes some unnecessary typos.

Fixes: 89077c7145c3 ("ARM: dts: Add HSUSB2 EHCI Support to Logic PD DM37xx
SOM-LV")

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Tony Lindgren May 1, 2018, 3:42 p.m. UTC | #1
* Adam Ford <aford173@gmail.com> [180430 10:50]:
> The pinmux controllers do not themselves need references to
> 'pinctrl-names' or 'pinctrl-0'
> 
> This patch removes some unnecessary typos.
> 
> Fixes: 89077c7145c3 ("ARM: dts: Add HSUSB2 EHCI Support to Logic PD DM37xx
> SOM-LV")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Applying into omap-for-v4.17/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Adam Ford May 4, 2018, 11:44 p.m. UTC | #2
On Tue, May 1, 2018 at 10:42 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Adam Ford <aford173@gmail.com> [180430 10:50]:
>> The pinmux controllers do not themselves need references to
>> 'pinctrl-names' or 'pinctrl-0'
>>
>> This patch removes some unnecessary typos.
>>
>> Fixes: 89077c7145c3 ("ARM: dts: Add HSUSB2 EHCI Support to Logic PD DM37xx
>> SOM-LV")
>>
>> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Applying into omap-for-v4.17/fixes thanks.

Can we revert this?  This apparently is required for the HSUSB2 port
to work and this patch breaks the USB.

Sorry for the noise.

adam
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren May 5, 2018, 7:42 p.m. UTC | #3
* Adam Ford <aford173@gmail.com> [180504 23:46]:
> On Tue, May 1, 2018 at 10:42 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Adam Ford <aford173@gmail.com> [180430 10:50]:
> >> The pinmux controllers do not themselves need references to
> >> 'pinctrl-names' or 'pinctrl-0'
> >>
> >> This patch removes some unnecessary typos.
> >>
> >> Fixes: 89077c7145c3 ("ARM: dts: Add HSUSB2 EHCI Support to Logic PD DM37xx
> >> SOM-LV")
> >>
> >> Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Applying into omap-for-v4.17/fixes thanks.
> 
> Can we revert this?  This apparently is required for the HSUSB2 port
> to work and this patch breaks the USB.
> 
> Sorry for the noise.

OK let's see.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/logicpd-som-lv.dtsi b/arch/arm/boot/dts/logicpd-som-lv.dtsi
index b47cac23a04b..a170e109191b 100644
--- a/arch/arm/boot/dts/logicpd-som-lv.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv.dtsi
@@ -204,8 +204,6 @@ 
 };
 
 &omap3_pmx_wkup {
-	pinctrl-names = "default";
-	pinctrl-0 = <&hsusb2_reset_pin>;
 	hsusb2_reset_pin: pinmux_hsusb1_reset_pin {
 		pinctrl-single,pins = <
 			OMAP3_WKUP_IOPAD(0x2a0e, PIN_OUTPUT | MUX_MODE4)	/* sys_boot2.gpio_4 */
@@ -232,8 +230,6 @@ 
 };
 
 &omap3_pmx_core2 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&hsusb2_2_pins>;
 	hsusb2_2_pins: pinmux_hsusb2_2_pins {
 		pinctrl-single,pins = <
 			OMAP3630_CORE2_IOPAD(0x25f0, PIN_OUTPUT | MUX_MODE3)            /* etk_d10.hsusb2_clk */