| Message ID | 17742083.Vu59BImYbG@amdc3058 (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Wednesday 02 May 2018 07:44 PM, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > Acked-by: Keerthy <j-keerthy@ti.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > =================================================================== > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 > @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ > 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, > 123400, > /* Index 940 - 945 */ > - 123800, 1242000, 124600, 124900, 125000, 125000, > + 123800, 124200, 124600, 124900, 125000, 125000, > }; > > /* OMAP54xx ES2.0 data */ >
On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote: > Entry for Index 941 has one zero too much. Fix it. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Good catch :) I'm curious, how did you spot it ? > --- > v2: > - Fix patch description. > > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > =================================================================== > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 > @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ > 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, > 123400, > /* Index 940 - 945 */ > - 123800, 1242000, 124600, 124900, 125000, 125000, > + 123800, 124200, 124600, 124900, 125000, 125000, > }; > > /* OMAP54xx ES2.0 data */ >
On Wednesday, May 02, 2018 05:49:31 PM Daniel Lezcano wrote: > On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Entry for Index 941 has one zero too much. Fix it. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Good catch :) Thanks. :) > I'm curious, how did you spot it ? While I was reading the driver code I've noticed that omap5430_adc_to_temp[] and dra752_adc_to_temp[] look pretty similar so I've diff-ed them to find the actual differences (+ to see if one of the tables can be removed). One of such differences was the line containing the incorrect entry. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c =================================================================== --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-04-30 16:23:42.000000000 +0200 +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c 2018-05-02 14:16:09.461434201 +0200 @@ -310,7 +310,7 @@ omap5430_adc_to_temp[ 119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000, 123400, /* Index 940 - 945 */ - 123800, 1242000, 124600, 124900, 125000, 125000, + 123800, 124200, 124600, 124900, 125000, 125000, }; /* OMAP54xx ES2.0 data */
Entry for Index 941 has one zero too much. Fix it. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- v2: - Fix patch description. drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)