[v2] thermal: ti-soc-thermal: fix incorrect entry in omap5430_adc_to_temp[]
diff mbox

Message ID 17742083.Vu59BImYbG@amdc3058
State New
Headers show

Commit Message

Bartlomiej Zolnierkiewicz May 2, 2018, 2:14 p.m. UTC
Entry for Index 941 has one zero too much. Fix it.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
v2:
- Fix patch description.

 drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

J, KEERTHY May 2, 2018, 3:44 p.m. UTC | #1
On Wednesday 02 May 2018 07:44 PM, Bartlomiej Zolnierkiewicz wrote:
> Entry for Index 941 has one zero too much. Fix it.
> 

Acked-by: Keerthy <j-keerthy@ti.com>

> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> v2:
> - Fix patch description.
> 
>  drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
> ===================================================================
> --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-04-30 16:23:42.000000000 +0200
> +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-05-02 14:16:09.461434201 +0200
> @@ -310,7 +310,7 @@ omap5430_adc_to_temp[
>  	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
>  	123400,
>  	/* Index 940 - 945 */
> -	123800, 1242000, 124600, 124900, 125000, 125000,
> +	123800, 124200, 124600, 124900, 125000, 125000,
>  };
>  
>  /* OMAP54xx ES2.0 data */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daniel Lezcano May 2, 2018, 3:49 p.m. UTC | #2
On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Entry for Index 941 has one zero too much. Fix it.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Good catch :)

I'm curious, how did you spot it ?

> ---
> v2:
> - Fix patch description.
> 
>  drivers/thermal/ti-soc-thermal/omap5-thermal-data.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
> ===================================================================
> --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-04-30 16:23:42.000000000 +0200
> +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-05-02 14:16:09.461434201 +0200
> @@ -310,7 +310,7 @@ omap5430_adc_to_temp[
>  	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
>  	123400,
>  	/* Index 940 - 945 */
> -	123800, 1242000, 124600, 124900, 125000, 125000,
> +	123800, 124200, 124600, 124900, 125000, 125000,
>  };
>  
>  /* OMAP54xx ES2.0 data */
>
Bartlomiej Zolnierkiewicz May 2, 2018, 4:20 p.m. UTC | #3
On Wednesday, May 02, 2018 05:49:31 PM Daniel Lezcano wrote:
> On Wed, May 02, 2018 at 04:14:32PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Entry for Index 941 has one zero too much. Fix it.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> Good catch :)

Thanks. :)

> I'm curious, how did you spot it ?

While I was reading the driver code I've noticed that
omap5430_adc_to_temp[] and dra752_adc_to_temp[] look pretty
similar so I've diff-ed them to find the actual differences
(+ to see if one of the tables can be removed). One of such
differences was the line containing the incorrect entry.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

Index: b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
===================================================================
--- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-04-30 16:23:42.000000000 +0200
+++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c	2018-05-02 14:16:09.461434201 +0200
@@ -310,7 +310,7 @@  omap5430_adc_to_temp[
 	119800, 120200, 120600, 121000, 121400, 121800, 122400, 122600, 123000,
 	123400,
 	/* Index 940 - 945 */
-	123800, 1242000, 124600, 124900, 125000, 125000,
+	123800, 124200, 124600, 124900, 125000, 125000,
 };
 
 /* OMAP54xx ES2.0 data */