Revert "vhost: make msg padding explicit"
diff mbox

Message ID 1525270740-460646-1-git-send-email-mst@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin May 2, 2018, 2:19 p.m. UTC
This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.

Unfortunately the padding will break 32 bit userspace.
Ouch. Need to add some compat code, revert for now.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/vhost.h | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller May 2, 2018, 2:27 p.m. UTC | #1
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 2 May 2018 17:19:05 +0300

> This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406.
> 
> Unfortunately the padding will break 32 bit userspace.
> Ouch. Need to add some compat code, revert for now.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied, thanks Michael.

Patch
diff mbox

diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index 5a8ad06..c51f8e5 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -68,7 +68,6 @@  struct vhost_iotlb_msg {
 
 struct vhost_msg {
 	int type;
-	int padding0;
 	union {
 		struct vhost_iotlb_msg iotlb;
 		__u8 padding[64];