| Message ID | 20180502144919.16780-1-andr2000@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Konrad? On 05/02/2018 05:49 PM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > > Add missing string constants for {feature|request}-raw-pointer > to align with the rest of the interface file. > > Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer") > > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- > xen/include/public/io/kbdif.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h > index 3ce54e9a44c1..daf4bc2063c9 100644 > --- a/xen/include/public/io/kbdif.h > +++ b/xen/include/public/io/kbdif.h > @@ -178,8 +178,10 @@ > #define XENKBD_DRIVER_NAME "vkbd" > > #define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer" > +#define XENKBD_FIELD_FEAT_RAW_POINTER "feature-raw-pointer" > #define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch" > #define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer" > +#define XENKBD_FIELD_REQ_RAW_POINTER "request-raw-pointer" > #define XENKBD_FIELD_REQ_MTOUCH "request-multi-touch" > #define XENKBD_FIELD_RING_GREF "page-gref" > #define XENKBD_FIELD_EVT_CHANNEL "event-channel" -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > > Add missing string constants for {feature|request}-raw-pointer > to align with the rest of the interface file. > > Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer") > > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Thank you! > --- > xen/include/public/io/kbdif.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h > index 3ce54e9a44c1..daf4bc2063c9 100644 > --- a/xen/include/public/io/kbdif.h > +++ b/xen/include/public/io/kbdif.h > @@ -178,8 +178,10 @@ > #define XENKBD_DRIVER_NAME "vkbd" > > #define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer" > +#define XENKBD_FIELD_FEAT_RAW_POINTER "feature-raw-pointer" > #define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch" > #define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer" > +#define XENKBD_FIELD_REQ_RAW_POINTER "request-raw-pointer" > #define XENKBD_FIELD_REQ_MTOUCH "request-multi-touch" > #define XENKBD_FIELD_RING_GREF "page-gref" > #define XENKBD_FIELD_EVT_CHANNEL "event-channel" > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > > > > Add missing string constants for {feature|request}-raw-pointer > > to align with the rest of the interface file. > > > > Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer") > > > > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Juergen, you OK with an release-ack? > > Thank you! > > --- > > xen/include/public/io/kbdif.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h > > index 3ce54e9a44c1..daf4bc2063c9 100644 > > --- a/xen/include/public/io/kbdif.h > > +++ b/xen/include/public/io/kbdif.h > > @@ -178,8 +178,10 @@ > > #define XENKBD_DRIVER_NAME "vkbd" > > > > #define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer" > > +#define XENKBD_FIELD_FEAT_RAW_POINTER "feature-raw-pointer" > > #define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch" > > #define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer" > > +#define XENKBD_FIELD_REQ_RAW_POINTER "request-raw-pointer" > > #define XENKBD_FIELD_REQ_MTOUCH "request-multi-touch" > > #define XENKBD_FIELD_RING_GREF "page-gref" > > #define XENKBD_FIELD_EVT_CHANNEL "event-channel" > > -- > > 2.17.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: > On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>> >>> Add missing string constants for {feature|request}-raw-pointer >>> to align with the rest of the interface file. >>> >>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer") >>> >>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> >> >> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Juergen, you OK with an release-ack? Yes: Release-acked-by: Juergen Gross <jgross@suse.com> Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/11/2018 06:15 PM, Juergen Gross wrote: > On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: >> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>>> >>>> Add missing string constants for {feature|request}-raw-pointer >>>> to align with the rest of the interface file. >>>> >>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer") >>>> >>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>> >>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >> Juergen, you OK with an release-ack? > Yes: > > Release-acked-by: Juergen Gross <jgross@suse.com> Is this ack for both patches or this one only? I see Konrad has applied this patch, but "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer" is still floating. > > Juergen Thank you, Oleksandr -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16/05/18 06:59, Oleksandr Andrushchenko wrote: > On 05/11/2018 06:15 PM, Juergen Gross wrote: >> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: >>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko >>>> wrote: >>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>>>> >>>>> Add missing string constants for {feature|request}-raw-pointer >>>>> to align with the rest of the interface file. >>>>> >>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and >>>>> "request-raw-pointer") >>>>> >>>>> Signed-off-by: Oleksandr Andrushchenko >>>>> <oleksandr_andrushchenko@epam.com> >>>> >>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>> Juergen, you OK with an release-ack? >> Yes: >> >> Release-acked-by: Juergen Gross <jgross@suse.com> > Is this ack for both patches or this one only? It was meant for patch 1 only. > I see Konrad has applied this patch, but > "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard > and pointer" > is still floating. In principle I'm fine with taking it for 4.11, but I think at this stage of the release there should be a formal request to include it. Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/17/2018 07:28 AM, Juergen Gross wrote: > On 16/05/18 06:59, Oleksandr Andrushchenko wrote: >> On 05/11/2018 06:15 PM, Juergen Gross wrote: >>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: >>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko >>>>> wrote: >>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>>>>> >>>>>> Add missing string constants for {feature|request}-raw-pointer >>>>>> to align with the rest of the interface file. >>>>>> >>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and >>>>>> "request-raw-pointer") >>>>>> >>>>>> Signed-off-by: Oleksandr Andrushchenko >>>>>> <oleksandr_andrushchenko@epam.com> >>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>>> Juergen, you OK with an release-ack? >>> Yes: >>> >>> Release-acked-by: Juergen Gross <jgross@suse.com> >> Is this ack for both patches or this one only? > It was meant for patch 1 only. Clear >> I see Konrad has applied this patch, but >> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard >> and pointer" >> is still floating. > In principle I'm fine with taking it for 4.11, but I think at this stage > of the release there should be a formal request to include it. ...and the request should come from Konrad? Or who else may request that? And, as I have r-b's from Konrad for both patches, will it be ok if we apply the corresponding changes to the kernel now, so my change to xen-kbdfront is unblocked? > > Juergen Thank you, Oleksandr -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 17/05/18 07:29, Oleksandr Andrushchenko wrote: > On 05/17/2018 07:28 AM, Juergen Gross wrote: >> On 16/05/18 06:59, Oleksandr Andrushchenko wrote: >>> On 05/11/2018 06:15 PM, Juergen Gross wrote: >>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: >>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko >>>>>> wrote: >>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>>>>>> >>>>>>> Add missing string constants for {feature|request}-raw-pointer >>>>>>> to align with the rest of the interface file. >>>>>>> >>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and >>>>>>> "request-raw-pointer") >>>>>>> >>>>>>> Signed-off-by: Oleksandr Andrushchenko >>>>>>> <oleksandr_andrushchenko@epam.com> >>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>>>> Juergen, you OK with an release-ack? >>>> Yes: >>>> >>>> Release-acked-by: Juergen Gross <jgross@suse.com> >>> Is this ack for both patches or this one only? >> It was meant for patch 1 only. > Clear >>> I see Konrad has applied this patch, but >>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard >>> and pointer" >>> is still floating. >> In principle I'm fine with taking it for 4.11, but I think at this stage >> of the release there should be a formal request to include it. > ...and the request should come from Konrad? > Or who else may request that? Normally the sender of the patch would make this request below the --- of the commit message, e.g.: --- This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side. The request can be made by anyone, of course, e.g. by replying to the patch mail and including the release manager as a recipient. > And, as I have r-b's from Konrad for both patches, > will it be ok if we apply the corresponding changes to the > kernel now, so my change to xen-kbdfront is unblocked? No, please don't do that. Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/17/2018 08:42 AM, Juergen Gross wrote: > On 17/05/18 07:29, Oleksandr Andrushchenko wrote: >> On 05/17/2018 07:28 AM, Juergen Gross wrote: >>> On 16/05/18 06:59, Oleksandr Andrushchenko wrote: >>>> On 05/11/2018 06:15 PM, Juergen Gross wrote: >>>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote: >>>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote: >>>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko >>>>>>> wrote: >>>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >>>>>>>> >>>>>>>> Add missing string constants for {feature|request}-raw-pointer >>>>>>>> to align with the rest of the interface file. >>>>>>>> >>>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and >>>>>>>> "request-raw-pointer") >>>>>>>> >>>>>>>> Signed-off-by: Oleksandr Andrushchenko >>>>>>>> <oleksandr_andrushchenko@epam.com> >>>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>>>>> Juergen, you OK with an release-ack? >>>>> Yes: >>>>> >>>>> Release-acked-by: Juergen Gross <jgross@suse.com> >>>> Is this ack for both patches or this one only? >>> It was meant for patch 1 only. >> Clear >>>> I see Konrad has applied this patch, but >>>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard >>>> and pointer" >>>> is still floating. >>> In principle I'm fine with taking it for 4.11, but I think at this stage >>> of the release there should be a formal request to include it. >> ...and the request should come from Konrad? >> Or who else may request that? > Normally the sender of the patch would make this request below the --- > of the commit message, e.g.: > --- > This patch should go into 4.11 as it is needed for a related Linux > kernel patch and the risk is next to zero for Xen due to only adding > some macros not in use on Xen side. > > The request can be made by anyone, of course, e.g. by replying to the > patch mail and including the release manager as a recipient. Great, thank you >> And, as I have r-b's from Konrad for both patches, >> will it be ok if we apply the corresponding changes to the >> kernel now, so my change to xen-kbdfront is unblocked? > No, please don't do that. Sure > > Juergen Thank you, Oleksandr -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h index 3ce54e9a44c1..daf4bc2063c9 100644 --- a/xen/include/public/io/kbdif.h +++ b/xen/include/public/io/kbdif.h @@ -178,8 +178,10 @@ #define XENKBD_DRIVER_NAME "vkbd" #define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer" +#define XENKBD_FIELD_FEAT_RAW_POINTER "feature-raw-pointer" #define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch" #define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer" +#define XENKBD_FIELD_REQ_RAW_POINTER "request-raw-pointer" #define XENKBD_FIELD_REQ_MTOUCH "request-multi-touch" #define XENKBD_FIELD_RING_GREF "page-gref" #define XENKBD_FIELD_EVT_CHANNEL "event-channel"