| Message ID | 20180503093107.25955-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 03, 2018 at 11:31:07AM +0200, Daniel Vetter wrote: > It's going away. > > v2: Try harder to find them all. > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Still Reviewed-by: Sean Paul <seanpaul@chromium.org> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Jordan Crouse <jcrouse@codeaurora.org> > Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> > Cc: Archit Taneja <architt@codeaurora.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 1 - > drivers/gpu/drm/msm/msm_debugfs.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c > index 8e0cb161754b..0ae5ace65462 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_device.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c > @@ -168,7 +168,6 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) > if (gpu->funcs->debugfs_init) { > gpu->funcs->debugfs_init(gpu, dev->primary); > gpu->funcs->debugfs_init(gpu, dev->render); > - gpu->funcs->debugfs_init(gpu, dev->control); > } > #endif > > diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c > index ba74cb4f94df..1ff3fda245d1 100644 > --- a/drivers/gpu/drm/msm/msm_debugfs.c > +++ b/drivers/gpu/drm/msm/msm_debugfs.c > @@ -140,9 +140,6 @@ int msm_debugfs_late_init(struct drm_device *dev) > if (ret) > return ret; > ret = late_init_minor(dev->render); > - if (ret) > - return ret; > - ret = late_init_minor(dev->control); > return ret; > } > > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, May 03, 2018 at 11:16:55AM -0400, Sean Paul wrote: > On Thu, May 03, 2018 at 11:31:07AM +0200, Daniel Vetter wrote: > > It's going away. > > > > v2: Try harder to find them all. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Still > Reviewed-by: Sean Paul <seanpaul@chromium.org> Ok, this compiled better, both remaining patches pushed. -Daniel > > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: Jordan Crouse <jcrouse@codeaurora.org> > > Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> > > Cc: Archit Taneja <architt@codeaurora.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > drivers/gpu/drm/msm/adreno/adreno_device.c | 1 - > > drivers/gpu/drm/msm/msm_debugfs.c | 3 --- > > 2 files changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c > > index 8e0cb161754b..0ae5ace65462 100644 > > --- a/drivers/gpu/drm/msm/adreno/adreno_device.c > > +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c > > @@ -168,7 +168,6 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) > > if (gpu->funcs->debugfs_init) { > > gpu->funcs->debugfs_init(gpu, dev->primary); > > gpu->funcs->debugfs_init(gpu, dev->render); > > - gpu->funcs->debugfs_init(gpu, dev->control); > > } > > #endif > > > > diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c > > index ba74cb4f94df..1ff3fda245d1 100644 > > --- a/drivers/gpu/drm/msm/msm_debugfs.c > > +++ b/drivers/gpu/drm/msm/msm_debugfs.c > > @@ -140,9 +140,6 @@ int msm_debugfs_late_init(struct drm_device *dev) > > if (ret) > > return ret; > > ret = late_init_minor(dev->render); > > - if (ret) > > - return ret; > > - ret = late_init_minor(dev->control); > > return ret; > > } > > > > -- > > 2.17.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 8e0cb161754b..0ae5ace65462 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -168,7 +168,6 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) if (gpu->funcs->debugfs_init) { gpu->funcs->debugfs_init(gpu, dev->primary); gpu->funcs->debugfs_init(gpu, dev->render); - gpu->funcs->debugfs_init(gpu, dev->control); } #endif diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c index ba74cb4f94df..1ff3fda245d1 100644 --- a/drivers/gpu/drm/msm/msm_debugfs.c +++ b/drivers/gpu/drm/msm/msm_debugfs.c @@ -140,9 +140,6 @@ int msm_debugfs_late_init(struct drm_device *dev) if (ret) return ret; ret = late_init_minor(dev->render); - if (ret) - return ret; - ret = late_init_minor(dev->control); return ret; }
It's going away. v2: Try harder to find them all. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Rob Clark <robdclark@gmail.com> Cc: Jordan Crouse <jcrouse@codeaurora.org> Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org> Cc: Archit Taneja <architt@codeaurora.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 - drivers/gpu/drm/msm/msm_debugfs.c | 3 --- 2 files changed, 4 deletions(-)