From patchwork Mon May 7 20:16:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 10384717 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DF65C60236 for ; Mon, 7 May 2018 20:17:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5ABB28B02 for ; Mon, 7 May 2018 20:17:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA4A928B5C; Mon, 7 May 2018 20:17:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6719C28B02 for ; Mon, 7 May 2018 20:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7C8D6B0005; Mon, 7 May 2018 16:16:59 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D2D376B000D; Mon, 7 May 2018 16:16:59 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1E946B026B; Mon, 7 May 2018 16:16:59 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f71.google.com (mail-pl0-f71.google.com [209.85.160.71]) by kanga.kvack.org (Postfix) with ESMTP id 83F5D6B0005 for ; Mon, 7 May 2018 16:16:59 -0400 (EDT) Received: by mail-pl0-f71.google.com with SMTP id f10-v6so391828pln.21 for ; Mon, 07 May 2018 13:16:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=ZkbjXuXmGO55DL15j170PYMzmg+KwhYXthb2CazHkFg=; b=WlZTCh9ZpNtMtbMNboIC/inYwzjf8y+oF/3Nm/WEb5FnMFaAItKN3PPnrCQH0feINT PPe+sD/1KRQyKxHQRlddRPwjeTLYUL3AmGOfotlLLHSKWwH0QwLxDYhjGLV5EB1mMs6B SYneH/EI/DXFk2CJK6yfbaloneKXk06ieAPrXGrrMPsE3OXXi6qgpf5ogrYdaoftZ8FT Pq2v5lsEQk0a/HP6x50a48GAOvkSgwEd2paf0KY3iz2j7CdzM3lKaaIQlvKCAdLQ+vzr Q9hZL1PtvzLikTsmCBsjWv44frRH1EYIJPBAViMjJmlvFv3vEAUdQH044VbB1zrMdSxv Xm1Q== X-Gm-Message-State: ALQs6tBFQPH3Uj/fWhhjAH1qN4WWeMDhg9vWoDGirBKUgPJSiv/8ScN4 29qbvbqcY5iZV3UMlFAEFMVabqxvmlaa9qB8GqSn/7R0TQIJKbqt7MGj6AGMwpET556VaIjzTu9 D7lgwY31F3fvmeA5xzXSmbNNMNTTzPT3/BWjEabCkUJG3xe5SIRTR9AUkylTdMnhacSAXkK+Kh5 +izRZlLAN+YA5/p8F3pu04QR6QTTE/iyyu1CsJWZfPBiwPXhbc7DSEFcKueXDESE88Cc8XF56zo 2VYFn+L1j+LvvrXb3AyLiDkJd/MBasm59k32hkUu11VKOTST6+CqhfGGC/q8rCHrBddGuavKpKT HE0UkGUW8kCCItw1Gc/WLb4XDCLOTlibUjEY/1uS92Aqr2FOzdwj9VUlmbkTFbpRkXdvjhSlZ+B J X-Received: by 10.98.204.8 with SMTP id a8mr37263281pfg.219.1525724219079; Mon, 07 May 2018 13:16:59 -0700 (PDT) X-Received: by 10.98.204.8 with SMTP id a8mr37263269pfg.219.1525724218244; Mon, 07 May 2018 13:16:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525724218; cv=none; d=google.com; s=arc-20160816; b=fK6tKXpQXy2nHr78qNUc84csJuGLKtEBfYXUr8bRy92pRDZg68LGT4gDdGXoNH0RmS ZPamVyCqWBsUKHJgpPwisL5BQJMKdiAGKk7J2X9K949pcDCMr1Xnb8sFVRYk2tHJwJRN SIJfXWdCIbiiCEZSz89WtkzDZfJ7dgkj3UTvNoupo00UnhjYnWidv1vTMFxDPmJp8Yhk f81oNU5c1jjudz9sM+PZGr0FchW+klmnL3tw6fjthWATQQ3hTfiZUen0WPpj8E9lfiEc XUoFTLmbSAU4AaSFTfRHQW21RCL1iIh0rEIWLvu6dmaFEuIS/RJhK4X84rQlX/Kx7pid 1bRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=ZkbjXuXmGO55DL15j170PYMzmg+KwhYXthb2CazHkFg=; b=woyk1h5f6WEjD2h4MTIDOsFGpawNpaywNVIUCCpYiboOVWzsm/Q3OM1x9Gx/65zciI 236DRsD+azyVYD1/2SRMoYfWpEQyZbEQ4XzXfnhA5oqWPbC61EDNsLp6xr0EsB6Nkl2a Z6hnn/c1elX7IFP8IYoDsDv0rTrBjxjJE4a3snGnv8KN4n5fbr3/tBX+aZonz9++h9w6 37cPdAHWYCC+/pjgY1qQOVtQ17YyH93F5G50Z/EkuOd8NRb4kFn91yw3kugJfEXWTpLI DYd6VERnSir6hbp6wfUWpO67S5agw+jxecVEjkep7ESc7Drr9lSEc9zPQNXEcogTUXUO ERBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=otxEheU2; spf=pass (google.com: domain of shakeelb@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b6-v6sor4946968plx.0.2018.05.07.13.16.58 for (Google Transport Security); Mon, 07 May 2018 13:16:58 -0700 (PDT) Received-SPF: pass (google.com: domain of shakeelb@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=otxEheU2; spf=pass (google.com: domain of shakeelb@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ZkbjXuXmGO55DL15j170PYMzmg+KwhYXthb2CazHkFg=; b=otxEheU289OjZU+O+u9CFaSsGRmyIymcfyEHrtTA/GtmIhJs7cTOsUZ9uXNUOKhaG7 KHEVvwBfVIEPo0MeNDLxpi7Qlxw5mZ4I66vrMsXrLmizFCMT97A5i6VZBtU236Y08Pt6 TntEQkpzksgtV2ZlL6dBP/0wzQeULYbYVF53VD/I15z4fAXU74MYhmHDTI+KTMJVEOrV Ln+95/VSGRkjuGaYCIU6TwfikXP0csDV6Cb82Xnz88uThZC9HGVoNDfDMOD/zwpefq/c +ftZp6K9GGs7OO+hQUi10DDoEyWoyGmaXpc3UJYvwv4Jy2BEaa0oVGirgBHuOOcZ3Sk9 rGvg== X-Google-Smtp-Source: AB8JxZrjeNtyydkZCKZJ0DGYxw2qebuHIwIatNBHR0r0GXnYhks7qqb/DG9uA+xvIvJmfJ6s9irOBg== X-Received: by 2002:a17:902:7d87:: with SMTP id a7-v6mr7517796plm.264.1525724217615; Mon, 07 May 2018 13:16:57 -0700 (PDT) Received: from shakeelb.mtv.corp.google.com ([2620:15c:2cb:201:3a5f:3a4f:fa44:6b63]) by smtp.gmail.com with ESMTPSA id 29sm14678406pfj.14.2018.05.07.13.16.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 13:16:55 -0700 (PDT) From: Shakeel Butt To: Michal Hocko , Andrew Morton , Greg Thelen , Johannes Weiner , Vladimir Davydov Cc: Linux MM , Cgroups , LKML , Junaid Shahid , Junaid Shahid , Shakeel Butt Subject: [PATCH] mm: memcontrol: drain memcg stock on force_empty Date: Mon, 7 May 2018 13:16:51 -0700 Message-Id: <20180507201651.165879-1-shakeelb@google.com> X-Mailer: git-send-email 2.17.0.441.gb46fe60e1d-goog X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Junaid Shahid The per-cpu memcg stock can retain a charge of upto 32 pages. On a machine with large number of cpus, this can amount to a decent amount of memory. Additionally force_empty interface might be triggering unneeded memcg reclaims. Signed-off-by: Junaid Shahid Signed-off-by: Shakeel Butt Acked-by: Michal Hocko --- mm/memcontrol.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e2d33a37f971..2c3c69524b49 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2841,6 +2841,9 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg) /* we call try-to-free pages for make this cgroup empty */ lru_add_drain_all(); + + drain_all_stock(memcg); + /* try to free all pages in this cgroup */ while (nr_retries && page_counter_read(&memcg->memory)) { int progress;