From patchwork Mon May 7 23:30:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 10384959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7FB086037F for ; Mon, 7 May 2018 23:30:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 739A828B5E for ; Mon, 7 May 2018 23:30:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65B1128B72; Mon, 7 May 2018 23:30:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D5F428B5E for ; Mon, 7 May 2018 23:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753116AbeEGXaJ (ORCPT ); Mon, 7 May 2018 19:30:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:57924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752938AbeEGXaH (ORCPT ); Mon, 7 May 2018 19:30:07 -0400 Received: from garbanzo.do-not-panic.com (c-73-15-241-2.hsd1.ca.comcast.net [73.15.241.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E59C62173F; Mon, 7 May 2018 23:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525735807; bh=NwR+/SbtnkjVaMSOFhUco7XYetszbtU7oc8tTDoRmBk=; h=From:To:Cc:Subject:Date:From; b=1mHxMabqtodfyLqXZKaHg7a4YnG8f6UNIZAWmOtyNDC2PkcLvwEGlY3pRrbdVj/5g 8BL3xuU21kAMP+tXQlAnhXCALSzW0mryg3dOjMZAQCrhkwi/2KK+/ok/Ur7+H0Ts6a ZAuEr+8QlUafgkG88vhZhGqMu2bshokpMX/wEY00= From: "Luis R. Rodriguez" To: viro@zeniv.linux.org.uk Cc: ast@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" Subject: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup() Date: Mon, 7 May 2018 16:30:02 -0700 Message-Id: <20180507233002.5571-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This makes it clearer this code is part of the coredump code, and is not an exported generic helper from kernel/umh.c. Signed-off-by: Luis R. Rodriguez --- fs/coredump.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/coredump.c b/fs/coredump.c index 1e2c87acac9b..566504781683 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -508,7 +508,7 @@ static void wait_for_dump_helpers(struct file *file) } /* - * umh_pipe_setup + * coredump_pipe_setup * helper function to customize the process used * to collect the core in userspace. Specifically * it sets up a pipe and installs it as fd 0 (stdin) @@ -518,7 +518,7 @@ static void wait_for_dump_helpers(struct file *file) * is a special value that we use to trap recursive * core dumps */ -static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) +static int coredump_pipe_setup(struct subprocess_info *info, struct cred *new) { struct file *files[2]; struct coredump_params *cp = (struct coredump_params *)info->data; @@ -606,7 +606,7 @@ void do_coredump(const siginfo_t *siginfo) } if (cprm.limit == 1) { - /* See umh_pipe_setup() which sets RLIMIT_CORE = 1. + /* See coredump_pipe_setup() which sets RLIMIT_CORE = 1. * * Normally core limits are irrelevant to pipes, since * we're not writing to the file system, but we use @@ -647,7 +647,8 @@ void do_coredump(const siginfo_t *siginfo) retval = -ENOMEM; sub_info = call_usermodehelper_setup(helper_argv[0], helper_argv, NULL, GFP_KERNEL, - umh_pipe_setup, NULL, &cprm); + coredump_pipe_setup, NULL, + &cprm); if (sub_info) retval = call_usermodehelper_exec(sub_info, UMH_WAIT_EXEC);