Message ID | 4994f263efbf6a2cb952d3d9839fb3b1737efde9.1526576613.git.gustavo.pimentel@synopsys.com (mailing list archive) |
---|---|
State | New, archived |
Delegated to: | Bjorn Helgaas |
Headers | show |
Hi Alan, On Thursday 17 May 2018 10:39 PM, Gustavo Pimentel wrote: > Change cdns_pcie_ep_raise_irq() signature, namely the interrupt_num > variable type from u8 to u16 to accommodate 2048 maximum MSI-X > interrupts. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > Acked-by: Alan Douglas <adouglas@cadence.com> Do you want to add MSI-X support to cadence PCIe? Thanks Kishon
On 31 May 2018 11:51, Kishon Vijay Abraham I wrote: > Hi Alan, > > On Thursday 17 May 2018 10:39 PM, Gustavo Pimentel wrote: > > Change cdns_pcie_ep_raise_irq() signature, namely the interrupt_num > > variable type from u8 to u16 to accommodate 2048 maximum MSI-X > > interrupts. > > > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > Acked-by: Alan Douglas <adouglas@cadence.com> > > Do you want to add MSI-X support to cadence PCIe? > I do want to add MSI-X support, in fact I have done some tests with a modified cadence driver with this set, so plan to submit a patch later.
On Monday 04 June 2018 08:38 PM, Alan Douglas wrote: > On 31 May 2018 11:51, Kishon Vijay Abraham I wrote: >> Hi Alan, >> >> On Thursday 17 May 2018 10:39 PM, Gustavo Pimentel wrote: >>> Change cdns_pcie_ep_raise_irq() signature, namely the interrupt_num >>> variable type from u8 to u16 to accommodate 2048 maximum MSI-X >>> interrupts. >>> >>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >>> Acked-by: Alan Douglas <adouglas@cadence.com> >> >> Do you want to add MSI-X support to cadence PCIe? >> > I do want to add MSI-X support, in fact I have done some tests with a > modified cadence driver with this set, so plan to submit a patch later. > cool, glad to hear! Thanks Kishon
diff --git a/drivers/pci/cadence/pcie-cadence-ep.c b/drivers/pci/cadence/pcie-cadence-ep.c index 3d8283e..6b713ca 100644 --- a/drivers/pci/cadence/pcie-cadence-ep.c +++ b/drivers/pci/cadence/pcie-cadence-ep.c @@ -363,7 +363,8 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, } static int cdns_pcie_ep_raise_irq(struct pci_epc *epc, u8 fn, - enum pci_epc_irq_type type, u8 interrupt_num) + enum pci_epc_irq_type type, + u16 interrupt_num) { struct cdns_pcie_ep *ep = epc_get_drvdata(epc);