diff mbox

[v5,07/12] ARM: dts: imx7s: add mipi phy power domain

Message ID 20180518092806.3829-8-rui.silva@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Rui Miguel Silva May 18, 2018, 9:28 a.m. UTC 
Add power domain index 0 related with mipi-phy to imx7s.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
---
 arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring (Arm) May 18, 2018, 4:50 p.m. UTC | #1 
On Fri, May 18, 2018 at 10:28:01AM +0100, Rui Miguel Silva wrote:
> Add power domain index 0 related with mipi-phy to imx7s.
> 
> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> ---
>  arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 4d42335c0dee..67450ad89940 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -636,6 +636,12 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> +					pgc_mipi_phy: pgc-power-domain@0 {

power-domain@0

> +						#power-domain-cells = <0>;
> +						reg = <0>;
> +						power-supply = <&reg_1p0d>;
> +					};
> +
>  					pgc_pcie_phy: pgc-power-domain@1 {

ditto.

>  						#power-domain-cells = <0>;
>  						reg = <1>;
> -- 
> 2.17.0
>
Rui Miguel Silva May 18, 2018, 9:54 p.m. UTC | #2 
Hi Rob,
On Fri 18 May 2018 at 16:50, Rob Herring wrote:
> On Fri, May 18, 2018 at 10:28:01AM +0100, Rui Miguel Silva 
> wrote:
>> Add power domain index 0 related with mipi-phy to imx7s.
>> 
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>>  arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/imx7s.dtsi 
>> b/arch/arm/boot/dts/imx7s.dtsi
>> index 4d42335c0dee..67450ad89940 100644
>> --- a/arch/arm/boot/dts/imx7s.dtsi
>> +++ b/arch/arm/boot/dts/imx7s.dtsi
>> @@ -636,6 +636,12 @@
>>  					#address-cells = <1>;
>>  					#size-cells = <0>;
>>  
>> +					pgc_mipi_phy: 
>> pgc-power-domain@0 {
>
> power-domain@0

I can change it, but...
>
>> + 
>> #power-domain-cells = <0>;
>> +						reg = <0>;
>> +						power-supply = 
>> <&reg_1p0d>;
>> +					};
>> +
>>  					pgc_pcie_phy: 
>>  pgc-power-domain@1 {
>
> ditto.

This was not introduced by my patch, it is already there and I was
trying to be coherent with the existing naming.
but let me know if you like me to change it also.

---
Cheers,
	Rui
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 4d42335c0dee..67450ad89940 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -636,6 +636,12 @@ 
 					#address-cells = <1>;
 					#size-cells = <0>;
 
+					pgc_mipi_phy: pgc-power-domain@0 {
+						#power-domain-cells = <0>;
+						reg = <0>;
+						power-supply = <&reg_1p0d>;
+					};
+
 					pgc_pcie_phy: pgc-power-domain@1 {
 						#power-domain-cells = <0>;
 						reg = <1>;