| Message ID | 1526704344-19615-1-git-send-email-yangx.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, May 19, 2018 at 12:32:24PM +0800, Xiao Yang wrote: > xfs/132 and xfs/133 running together got the following error: > ------------------------------------------------------------ > ... > xfs/132 1s ... 1s > xfs/133 1s ... [failed, exit status 1] - output mismatch (see /var/lib/xfstests/results//xfs/133.out.bad) > ... > QA output created by 133 > -Format and mount > -Corrupt filesystem > -Remount, try to append > -Write did not succeed (ok). > +SCRATCH_DEV=/dev/sda11 is mounted but not on SCRATCH_MNT=common/config: - aborting > +Already mounted result: > +/dev/sda11 /mnt/xfstests/scratch > ... > ------------------------------------------------------------ > > xfs/132 led to XFS shutdown due to the corrupted inode, but it didn't rectify XFS > by umount scratch device. AFAIK, we don't have to unmount the scratch device when a test finishes - the test harness is supposed to do that and make sure that it is in the correct state for the next test to run. It seems that somewhere along the line this got broken. - I'm guessing the fact that this test also says "don't check the scratch device" the test harness is failing to unmount it because it's not running _check_scratch_device. I'm guessing that it should at least run _scratch_unmount.... Cheers, Dave.
diff --git a/tests/xfs/132 b/tests/xfs/132 index 6bb03e7..960096f 100755 --- a/tests/xfs/132 +++ b/tests/xfs/132 @@ -68,6 +68,8 @@ _scratch_mount # The corrupt inode should be tripped over during these initial file creates. touch $SCRATCH_MNT/file{0,1,2,3,4,5}{0,1,2,3,4,5} 2>&1 | _filter_scratch +_scratch_unmount + # success, all done status=0 exit
xfs/132 and xfs/133 running together got the following error: ------------------------------------------------------------ ... xfs/132 1s ... 1s xfs/133 1s ... [failed, exit status 1] - output mismatch (see /var/lib/xfstests/results//xfs/133.out.bad) ... QA output created by 133 -Format and mount -Corrupt filesystem -Remount, try to append -Write did not succeed (ok). +SCRATCH_DEV=/dev/sda11 is mounted but not on SCRATCH_MNT=common/config: - aborting +Already mounted result: +/dev/sda11 /mnt/xfstests/scratch ... ------------------------------------------------------------ xfs/132 led to XFS shutdown due to the corrupted inode, but it didn't rectify XFS by umount scratch device. Subsequent xfs/133 got a wrong canonical mount point path(i.e. SCRATCH_MNT='common/config: SCRATCH_MNT (/mnt/xfstests/scratch) is not a directory') for $SCRATCH_DEV when calling _canonicalize_mountpoint in common/config, and finally led to the failure of _check_mounted_on. Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> --- tests/xfs/132 | 2 ++ 1 file changed, 2 insertions(+)