From patchwork Thu May 24 09:57:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 10424077 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 620956019D for ; Thu, 24 May 2018 10:52:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F319293BD for ; Thu, 24 May 2018 10:52:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 589E629432; Thu, 24 May 2018 10:52:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D51E29422 for ; Thu, 24 May 2018 10:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032624AbeEXKt7 (ORCPT ); Thu, 24 May 2018 06:49:59 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:32867 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030481AbeEXJ5e (ORCPT ); Thu, 24 May 2018 05:57:34 -0400 Received: by mail-wr0-f195.google.com with SMTP id a15-v6so1966719wrm.0 for ; Thu, 24 May 2018 02:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zJSNYnlPAAyAhFc+i4T3g8zcQjGcB27fQWh/R9b/eIc=; b=Nr/GVY/jMq8WEc7NYjy+SBoUVyPCDrqI6KxO2UpdJOHQXZnSbySpUU5feg4VWzz7uo n0hFQoskDHjhvYd72+6ThQXbSCqjioZpcmXFbnfNJz781XJrIEN/2z+r/2tBolRGmKFR RRhE4wPWeow/tOjTxhgpGInuAYbrGVafn3nTjT+7kVsmaVzpFgtImTTOFkskKbk3ma3g 9LpoGVPB6fe+htYrDLQQAKEA15nXGKsYPFLuuffwAPYGyGgmXcX89qeeLAOE10xjM8Mr 5WXRIvO9VQe/vnF915JR+h5hMRc78sAPuKUMXDitQQHPmE3G7PbiczHwJXx+sNFeiN0f nc/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zJSNYnlPAAyAhFc+i4T3g8zcQjGcB27fQWh/R9b/eIc=; b=qIzBtyV66VjgztQVVlc83K7+F5jVcvCTwo8JTxKvDAmfgDNbcM3wlZLJoIU4Tg8MNI c54e0m45F2pI8siuXbuoPcY4TpdM56bvYDteeAT55twKWIr9ugL8sAO/NGFit3T1CtT2 mW1ddl3LbDJAyY3X/fzhJjdlotoexJFbDX0oY3XXsgajoxywyxhnRKaN0UaaSVztA8Sn jDhWKBCgOu4Sjytbq63Z5uacV+Vb1vYfalWw2ellPYD1xWoLTxnIOPEOGzZIB1HeAAFB y/qQBPI22r/Myf27xO9FiYjFDOGHwqrrdP0MR8fMvmApsCrTYuhTyczn7IX8pCbMK/wP u0PA== X-Gm-Message-State: ALKqPwekC40f6s6ADQ38ZP8/ytW/G8O38iK5LCo6F3CdeCsfZb4CYPx2 iLCyH+P/hkBWwAfT5h+B/eFljQ== X-Google-Smtp-Source: AB8JxZqyWYPby7iskYecAUtf/iS1HQTtNMQ8ssbm5H3Hz8TUIzlcLX3R/YIIhAh6yPuzsCnFOLLy4A== X-Received: by 2002:adf:88b6:: with SMTP id f51-v6mr5046173wrf.55.1527155852880; Thu, 24 May 2018 02:57:32 -0700 (PDT) Received: from bender.baylibre.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id b66-v6sm6868525wma.48.2018.05.24.02.57.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 May 2018 02:57:31 -0700 (PDT) From: Neil Armstrong To: airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org, olof@lixom.net, seanpaul@google.com Cc: Neil Armstrong , sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com Subject: [PATCH v6 5/6] mfd: cros_ec_dev: Add CEC sub-device registration Date: Thu, 24 May 2018 11:57:20 +0200 Message-Id: <1527155841-28494-6-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1527155841-28494-1-git-send-email-narmstrong@baylibre.com> References: <1527155841-28494-1-git-send-email-narmstrong@baylibre.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra Acked-by: Hans Verkuil --- drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 1d6dc5c..272969e 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -383,6 +383,10 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec) kfree(msg); } +static const struct mfd_cell cros_ec_cec_cells[] = { + { .name = "cros-ec-cec" } +}; + static const struct mfd_cell cros_ec_rtc_cells[] = { { .name = "cros-ec-rtc" } }; @@ -426,6 +430,18 @@ static int ec_device_probe(struct platform_device *pdev) if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) cros_ec_sensors_register(ec); + /* Check whether this EC instance has CEC host command support */ + if (cros_ec_check_features(ec, EC_FEATURE_CEC)) { + retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO, + cros_ec_cec_cells, + ARRAY_SIZE(cros_ec_cec_cells), + NULL, 0, NULL); + if (retval) + dev_err(ec->dev, + "failed to add cros-ec-cec device: %d\n", + retval); + } + /* Check whether this EC instance has RTC host command support */ if (cros_ec_check_features(ec, EC_FEATURE_RTC)) { retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO,