iio: adc: sun4i-gpadc: select REGMAP_IRQ
diff mbox

Message ID 20180525153451.3164970-1-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann May 25, 2018, 3:34 p.m. UTC
We can't call regmap_irq_get_virq() unless the regmap-irq support
is enabled:

drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'

I came across this in a randconfig build now, but I guess this is
a much older problem that I simply never hit before because regmap_irq
is usually enabled by one of the other drivers that need it.

Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron May 27, 2018, 9:35 a.m. UTC | #1
On Fri, 25 May 2018 17:34:23 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> We can't call regmap_irq_get_virq() unless the regmap-irq support
> is enabled:
> 
> drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
> sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'
> 
> I came across this in a randconfig build now, but I guess this is
> a much older problem that I simply never hit before because regmap_irq
> is usually enabled by one of the other drivers that need it.
> 
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to the togreg branch of iio.git.  I might move it to the fixes
branch if the merge window opens shortly so as to get it upstream
faster. Pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 9da79070357c..13922b595503 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -717,6 +717,7 @@ config SUN4I_GPADC
>  	depends on IIO
>  	depends on MFD_SUN4I_GPADC || MACH_SUN8I
>  	depends on THERMAL || !THERMAL_OF
> +	select REGMAP_IRQ
>  	help
>  	  Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
>  	  GPADC. This ADC provides 4 channels which can be used as an ADC or as

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 9da79070357c..13922b595503 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -717,6 +717,7 @@  config SUN4I_GPADC
 	depends on IIO
 	depends on MFD_SUN4I_GPADC || MACH_SUN8I
 	depends on THERMAL || !THERMAL_OF
+	select REGMAP_IRQ
 	help
 	  Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
 	  GPADC. This ADC provides 4 channels which can be used as an ADC or as