[next] ALSA: xen-front: remove redundant error check on ret
diff mbox

Message ID 20180527212312.23997-1-colin.king@canonical.com
State New
Headers show

Commit Message

Colin King May 27, 2018, 9:23 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The error for a -ve value in ret is redundant as all previous
assignments to ret have an associated -ve check and hence it
is impossible for ret to be less that zero at the point of the
check.  Remove this redundant error check.

Detected by CoveritScan, CID#1469407 ("Logically Dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/xen/xen_snd_front_evtchnl.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Takashi Sakamoto May 27, 2018, 10:42 p.m. UTC | #1
Hi,

On May 28 2018 06:23, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The error for a -ve value in ret is redundant as all previous
> assignments to ret have an associated -ve check and hence it
> is impossible for ret to be less that zero at the point of the
> check.  Remove this redundant error check.
> 
> Detected by CoveritScan, CID#1469407 ("Logically Dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   sound/xen/xen_snd_front_evtchnl.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> index d70a62e7f910..102d6e096cc8 100644
> --- a/sound/xen/xen_snd_front_evtchnl.c
> +++ b/sound/xen/xen_snd_front_evtchnl.c
> @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
>   			}
>   		}
>   	}
> -	if (ret < 0)
> -		goto fail;
>   
>   	front_info->num_evt_pairs = num_streams;
>   	return 0;

Yep. All branches for error path on the nested for loop have goto 
statement, thus no need to check error outer the loop.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Takashi Sakamoto
Takashi Iwai May 28, 2018, 9:29 a.m. UTC | #2
On Mon, 28 May 2018 00:42:12 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On May 28 2018 06:23, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The error for a -ve value in ret is redundant as all previous
> > assignments to ret have an associated -ve check and hence it
> > is impossible for ret to be less that zero at the point of the
> > check.  Remove this redundant error check.
> >
> > Detected by CoveritScan, CID#1469407 ("Logically Dead code")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >   sound/xen/xen_snd_front_evtchnl.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> > index d70a62e7f910..102d6e096cc8 100644
> > --- a/sound/xen/xen_snd_front_evtchnl.c
> > +++ b/sound/xen/xen_snd_front_evtchnl.c
> > @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
> >   			}
> >   		}
> >   	}
> > -	if (ret < 0)
> > -		goto fail;
> >     	front_info->num_evt_pairs = num_streams;
> >   	return 0;
> 
> Yep. All branches for error path on the nested for loop have goto
> statement, thus no need to check error outer the loop.
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi

Patch
diff mbox

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index d70a62e7f910..102d6e096cc8 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -351,8 +351,6 @@  int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
 			}
 		}
 	}
-	if (ret < 0)
-		goto fail;
 
 	front_info->num_evt_pairs = num_streams;
 	return 0;