Message ID | 20180530071613.125768-3-keiichiw@chromium.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 05/30/2018 09:16 AM, Keiichi Watanabe wrote: > Add V4L2_CID_MPEG_VIDEO_VP9_PROFILE control in MediaTek decoder's > driver. > MediaTek decoder only supports profile 0 for now. > > Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > index 86f0a7134365..f9393504356d 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > @@ -1400,6 +1400,12 @@ int mtk_vcodec_dec_ctrls_setup(struct mtk_vcodec_ctx *ctx) > V4L2_CID_MIN_BUFFERS_FOR_CAPTURE, > 0, 32, 1, 1); > ctrl->flags |= V4L2_CTRL_FLAG_VOLATILE; > + v4l2_ctrl_new_std_menu(&ctx->ctrl_hdl, > + &mtk_vcodec_dec_ctrl_ops, > + V4L2_CID_MPEG_VIDEO_VP9_PROFILE, > + V4L2_MPEG_VIDEO_VP9_PROFILE_3, It makes no sense to set max to PROFILE_3 if PROFILE_0 is the only choice. Just set max to PROFILE_0 as well. > + ~(1U << V4L2_MPEG_VIDEO_VP9_PROFILE_0), > + V4L2_MPEG_VIDEO_VP9_PROFILE_0); > > if (ctx->ctrl_hdl.error) { > mtk_v4l2_err("Adding control failed %d", > -- > 2.17.0.921.gf22659ad46-goog > Regards, Hans
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c index 86f0a7134365..f9393504356d 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c @@ -1400,6 +1400,12 @@ int mtk_vcodec_dec_ctrls_setup(struct mtk_vcodec_ctx *ctx) V4L2_CID_MIN_BUFFERS_FOR_CAPTURE, 0, 32, 1, 1); ctrl->flags |= V4L2_CTRL_FLAG_VOLATILE; + v4l2_ctrl_new_std_menu(&ctx->ctrl_hdl, + &mtk_vcodec_dec_ctrl_ops, + V4L2_CID_MPEG_VIDEO_VP9_PROFILE, + V4L2_MPEG_VIDEO_VP9_PROFILE_3, + ~(1U << V4L2_MPEG_VIDEO_VP9_PROFILE_0), + V4L2_MPEG_VIDEO_VP9_PROFILE_0); if (ctx->ctrl_hdl.error) { mtk_v4l2_err("Adding control failed %d",
Add V4L2_CID_MPEG_VIDEO_VP9_PROFILE control in MediaTek decoder's driver. MediaTek decoder only supports profile 0 for now. Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.17.0.921.gf22659ad46-goog