kselftests: fix ptr_ret.cocci warnings
diff mbox

Message ID 20180531064535.GA53792@lkp-ib04
State New
Headers show

Commit Message

Fengguang Wu May 31, 2018, 6:45 a.m. UTC
From: kbuild test robot <fengguang.wu@intel.com>

lib/test_atomic_sections.c:66:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 3b0e47f0ade1 ("kselftests: Add tests for the preemptoff and irqsoff tracers")
CC: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

 test_atomic_sections.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Joel Fernandes May 31, 2018, 7:14 a.m. UTC | #1
On Thu, May 31, 2018 at 02:45:35PM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> 
> lib/test_atomic_sections.c:66:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Fixes: 3b0e47f0ade1 ("kselftests: Add tests for the preemptoff and irqsoff tracers")

Seems a simple cosmetic/style fix. I can fold it into this patch. thanks,

 - Joel

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

--- a/lib/test_atomic_sections.c
+++ b/lib/test_atomic_sections.c
@@ -63,10 +63,7 @@  static int __init atomic_sect_init(void)
 	snprintf(task_name, 50, "%s dis test", atomic_mode);
 
 	test_task = kthread_run((void*)atomic_sect_run, NULL, task_name);
-	if (IS_ERR(test_task))
-		return PTR_ERR(test_task);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(test_task);
 }
 
 static void __exit atomic_sect_exit(void)