From patchwork Mon Jun 4 22:31:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10447391 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AB50C603D7 for ; Mon, 4 Jun 2018 22:31:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91AD3293CA for ; Mon, 4 Jun 2018 22:31:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85F86293F6; Mon, 4 Jun 2018 22:31:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3088F293CA for ; Mon, 4 Jun 2018 22:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbeFDWb5 (ORCPT ); Mon, 4 Jun 2018 18:31:57 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:52069 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbeFDWby (ORCPT ); Mon, 4 Jun 2018 18:31:54 -0400 Received: by mail-it0-f65.google.com with SMTP id n7-v6so1020109itn.1 for ; Mon, 04 Jun 2018 15:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=hqc8oGfBqkD2LYwuBiwB71c/BsqpEU5Y4kI8H2N3Lk0=; b=QzJhVIZNGe/HZ5gNabNugDyIThhCAFpVCxiWPiByefXjoO9FWHLz0YxyJuSPobvVjG IeeDNdRR1oe+qx0iVqRj5cq9Qyf4y33ZfDzQf+e4XjX6/QKIxurJjERyZI8AcI/cZLxH J9QoB/gUCRg3WuTM1AThlPAcsYQdcejR0IsLuHYWwVPBgR9S4bEbD8ITIbW3DtP5fgEg FOyg59ZUaNmHDj1IOBPES4uGne1YkmEhjMwF20FgA21CMntyQtFiOKnFeTdIoWSeZAA7 FsK6jIg4FRVrcoIHzIKuOogb/1p0cvHjEh70LclLNmPlGb8/5YfjdOFBBlJvog0muC8E gRlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hqc8oGfBqkD2LYwuBiwB71c/BsqpEU5Y4kI8H2N3Lk0=; b=eqd0O3PaZVU6wUrXkw1ro9ke/88r+iaI4vtMGdWrV9UtS9jJPTV7uijE2vHsmKubfj wEskI5bHoDUW+kQp1+Z+TGost3pSZx8PbJ4ZkbXeXVrWPcDSJFLGTrda/gbCCihvmJr3 FraTfsc0ZGglc1jlYL0gAPbJZ+qrlGaw/D3ycTApo+lkVwDTiTQTQehWq8AbH2/2GA/6 Pi33kCgmuHZeiiqQIYYcGWxHFhAH05GsXtkfopzbWjABhvv22awdGlKOQAawCO33WExG 7S5MNpIn8dLU0FGE0N6WrziVWvvOmokSVU/1c+Yu5V+DxX3/SOuJcyWs05EqvVembVry /+OA== X-Gm-Message-State: APt69E0LKVBDKqGlCqnMTtnMzwaC+JVwTVtruMAn8MROZgakomdbTmtP nIMrkwZABaGYWu2pqYACdNkTduw= X-Google-Smtp-Source: ADUXVKLl5ORHi4a/zfyu2YjXRCd4uPV+7Mif6qEMJ9xiqB/YrYfHzUwS31g2xPhKp0Nqtgo8j1NyJA== X-Received: by 2002:a24:efc2:: with SMTP id i185-v6mr8986134ith.57.1528151513804; Mon, 04 Jun 2018 15:31:53 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id s5-v6sm4309480ioj.13.2018.06.04.15.31.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 15:31:53 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 03/11] NFSv4: Don't ask for delegated attributes when revalidating the inode Date: Mon, 4 Jun 2018 18:31:21 -0400 Message-Id: <20180604223129.121477-3-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604223129.121477-2-trond.myklebust@hammerspace.com> References: <20180604223129.121477-1-trond.myklebust@hammerspace.com> <20180604223129.121477-2-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Trond Myklebust Again, when revalidating the inode, we don't need to ask for attributes for which we are authoritative. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index cd60e8360ef2..744a6367618d 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3832,9 +3832,10 @@ static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle, struct nfs_fattr *fattr, struct nfs4_label *label, struct inode *inode) { + __u32 bitmask[NFS4_BITMASK_SZ]; struct nfs4_getattr_arg args = { .fh = fhandle, - .bitmask = server->attr_bitmask, + .bitmask = bitmask, }; struct nfs4_getattr_res res = { .fattr = fattr, @@ -3847,7 +3848,7 @@ static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle, .rpc_resp = &res, }; - args.bitmask = nfs4_bitmask(server, label); + nfs4_bitmap_copy_adjust(bitmask, nfs4_bitmask(server, label), inode); nfs_fattr_init(fattr); return nfs4_call_sync(server->client, server, &msg, &args.seq_args, &res.seq_res, 0);