From patchwork Mon Jun 4 22:31:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10447395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E6DF600CA for ; Mon, 4 Jun 2018 22:32:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25E00293CA for ; Mon, 4 Jun 2018 22:32:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A882293F6; Mon, 4 Jun 2018 22:32:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C6153293CA for ; Mon, 4 Jun 2018 22:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671AbeFDWb7 (ORCPT ); Mon, 4 Jun 2018 18:31:59 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:38124 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbeFDWb4 (ORCPT ); Mon, 4 Jun 2018 18:31:56 -0400 Received: by mail-it0-f67.google.com with SMTP id v83-v6so996861itc.3 for ; Mon, 04 Jun 2018 15:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=n8zil4JluqpM77RGx5h1HHeKvO34WSXt38pdAjneUUE=; b=jEdtVF6gY3wTlIQfwTlYpPamX9kT46XpgL1pEaHuvt7f4zRdsq9EMWGSYTmBAnMlCD iLzC71pCs65zOPsYGpsFnKq/RflYVyUzZGV3xnNdLs5TNCwusCaXTpVqbJKx1bZb3CBk ek0ZvP/60//X8OfpnFwLLYyp0rVh51i/U4opugvWMif0ES3ouvHpDSvjZ5vImoBrR9Pd d9uztJm7IWDYR7KDUSNqZ8kEraCy5wJTqLqR02vWYoUpdeuNc0eBJY3eT9PjUDk+jJwP bgAV4oF1uwb1U+KDGFTdCqWcCKS0KF7J35Na1glDW0tFfsfDUEnm31Gwljn/RPy9cqFR 3q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n8zil4JluqpM77RGx5h1HHeKvO34WSXt38pdAjneUUE=; b=HjuGgTqDm48cUiuiADef5GTaIPJnjBEeSy7FO9DrmICuogq70+G/es/RIJVVG+9GGu yuaBu/OD497AJNgO/TbEpq4UNv71zedqmxuthBYLHNrJ86y4awCKHZGoKld2GEAAQs2O nBhbDHNS1u4OPJDz5nHemCxhyRx1D2oMzwrxNcI3j5yLboP+QKLrtBvIE/eKDKJbWUyM m5e2hDGnf40l+UUfAr8MgkSCzjMrEizH2TfsQukd0dWIptFiERhiJlqpJOuw+izLtMb1 wCAQ0aXRnbUggIb7xhOJNU/JEQ5NHg2z1eP7QhKT84OdPytICtLvkOOvhaZIWpATxThV rO0w== X-Gm-Message-State: APt69E33113HTyfjphasJ0JhT/+eEOAE5rAW91N6YXsapMWMjn39vetJ QT8nieBoYgn2pLLAQBPy565y8Z0= X-Google-Smtp-Source: ADUXVKJnyNw+ppHuWGjIhY49VnpAevvQbC9eHTx1CM5mpbYatWQcnUYkbV3MBBYnbohC7u18ycZI6Q== X-Received: by 2002:a24:a70e:: with SMTP id a14-v6mr1762462itf.115.1528151515258; Mon, 04 Jun 2018 15:31:55 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id s5-v6sm4309480ioj.13.2018.06.04.15.31.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 15:31:54 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 05/11] NFSv4: Ignore NFS_INO_REVAL_FORCED in nfs4_proc_access Date: Mon, 4 Jun 2018 18:31:23 -0400 Message-Id: <20180604223129.121477-5-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604223129.121477-4-trond.myklebust@hammerspace.com> References: <20180604223129.121477-1-trond.myklebust@hammerspace.com> <20180604223129.121477-2-trond.myklebust@hammerspace.com> <20180604223129.121477-3-trond.myklebust@hammerspace.com> <20180604223129.121477-4-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If we hold a delegation, we don't need to care about whether or not the inode attributes are up to date. We know we can cache the results of this call regardless. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 544cdcb79b4f..f413d0c8c837 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -4114,7 +4114,7 @@ static int _nfs4_proc_access(struct inode *inode, struct nfs_access_entry *entry }; int status = 0; - if (!nfs_have_delegated_attributes(inode)) { + if (!nfs4_have_delegation(inode, FMODE_READ)) { res.fattr = nfs_alloc_fattr(); if (res.fattr == NULL) return -ENOMEM;