| Message ID | 20180605092209.22887-7-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
On Tue, Jun 05, 2018 at 11:22:06AM +0200, Enric Balletbo i Serra wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > drivers/input/keyboard/cros_ec_keyb.c | 26 ++++---------------------- > 1 file changed, 4 insertions(+), 22 deletions(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index 79eb29550c34..342513ec0ede 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -1,25 +1,7 @@ > -/* > - * ChromeOS EC keyboard driver > - * > - * Copyright (C) 2012 Google, Inc > - * > - * This software is licensed under the terms of the GNU General Public > - * License version 2, as published by the Free Software Foundation, and > - * may be copied, distributed, and modified under those terms. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * This driver uses the Chrome OS EC byte-level message-based protocol for > - * communicating the keyboard state (which keys are pressed) from a keyboard EC > - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing, > - * but everything else (including deghosting) is done here. The main > - * motivation for this is to keep the EC firmware as simple as possible, since > - * it cannot be easily upgraded and EC flash/IRAM space is relatively > - * expensive. > - */ Ugh, why did you remove this last paragraph? It has nothing to do with license notice and should have been kept. > +// SPDX-License-Identifier: GPL-2.0+ > +// ChromeOS EC keyboard driver > +// > +// Copyright (C) 2012 Google, Inc. > > #include <linux/module.h> > #include <linux/bitops.h> > -- > 2.17.1 > Thanks.
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 79eb29550c34..342513ec0ede 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -1,25 +1,7 @@ -/* - * ChromeOS EC keyboard driver - * - * Copyright (C) 2012 Google, Inc - * - * This software is licensed under the terms of the GNU General Public - * License version 2, as published by the Free Software Foundation, and - * may be copied, distributed, and modified under those terms. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * This driver uses the Chrome OS EC byte-level message-based protocol for - * communicating the keyboard state (which keys are pressed) from a keyboard EC - * to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing, - * but everything else (including deghosting) is done here. The main - * motivation for this is to keep the EC firmware as simple as possible, since - * it cannot be easily upgraded and EC flash/IRAM space is relatively - * expensive. - */ +// SPDX-License-Identifier: GPL-2.0+ +// ChromeOS EC keyboard driver +// +// Copyright (C) 2012 Google, Inc. #include <linux/module.h> #include <linux/bitops.h>
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- drivers/input/keyboard/cros_ec_keyb.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-)