Message ID | 20180606204724.26055-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show |
> - if (ret == 0) > + if (!mmc_send_tuning(mmc, opcode, NULL)) I'd prefer '== 0' here as it makes clearer that we are checking for the good case here. But in general, the patch makes sense to me.
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 3080299303045adc..e805f84b24a2def8 100644 --- a/drivers/mmc/host/tmio_mmc_core.c +++ b/drivers/mmc/host/tmio_mmc_core.c @@ -804,10 +804,7 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) if (host->prepare_tuning) host->prepare_tuning(host, i % host->tap_num); - ret = mmc_send_tuning(mmc, opcode, NULL); - if (ret && ret != -EILSEQ) - goto out; - if (ret == 0) + if (!mmc_send_tuning(mmc, opcode, NULL)) set_bit(i, host->taps); usleep_range(1000, 1200);