| Message ID | 20180608191100.21751-1-rkir@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, could you please confirm you received our patches? Thank you. Regards, Roman. On Fri, Jun 8, 2018 at 12:11 PM <rkir@google.com> wrote: > > From: Roman Kiryanov <rkir@google.com> > > Address issues pointed by checkpatch.pl > > Signed-off-by: Roman Kiryanov <rkir@google.com> > --- > Changes in v2: > - Updated the commit message to include "video: fbdev:" and added a description. > > drivers/video/fbdev/goldfishfb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c > index 3b70044773b6..de29c4ff77e5 100644 > --- a/drivers/video/fbdev/goldfishfb.c > +++ b/drivers/video/fbdev/goldfishfb.c > @@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct fb_var_screeninfo *var, > static int goldfish_fb_set_par(struct fb_info *info) > { > struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb); > + > if (fb->rotation != fb->fb.var.rotate) { > info->fix.line_length = info->var.xres * 2; > fb->rotation = fb->fb.var.rotate; > @@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct fb_var_screeninfo *var, > wait_event_timeout(fb->wait, > fb->base_update_count != base_update_count, HZ / 15); > if (fb->base_update_count == base_update_count) > - pr_err("goldfish_fb_pan_display: timeout waiting for base update\n"); > + pr_err("%s: timeout waiting for base update\n", __func__); > return 0; > } > > static int goldfish_fb_blank(int blank, struct fb_info *info) > { > struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb); > + > switch (blank) { > case FB_BLANK_NORMAL: > writel(1, fb->reg_base + FB_SET_BLANK); > -- > 2.18.0.rc1.242.g61856ae69a-goog >
On Friday, June 15, 2018 04:47:03 PM Roman Kiryanov wrote: > Hi, > > could you please confirm you received our patches? Thank you. Hi, Yes, they are in my inbox waiting for their turn (I'll start queuing patches for v4.19 later this week). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Friday, June 08, 2018 12:10:58 PM rkir@google.com wrote: > From: Roman Kiryanov <rkir@google.com> > > Address issues pointed by checkpatch.pl > > Signed-off-by: Roman Kiryanov <rkir@google.com> Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 3b70044773b6..de29c4ff77e5 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c @@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct fb_var_screeninfo *var, static int goldfish_fb_set_par(struct fb_info *info) { struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb); + if (fb->rotation != fb->fb.var.rotate) { info->fix.line_length = info->var.xres * 2; fb->rotation = fb->fb.var.rotate; @@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct fb_var_screeninfo *var, wait_event_timeout(fb->wait, fb->base_update_count != base_update_count, HZ / 15); if (fb->base_update_count == base_update_count) - pr_err("goldfish_fb_pan_display: timeout waiting for base update\n"); + pr_err("%s: timeout waiting for base update\n", __func__); return 0; } static int goldfish_fb_blank(int blank, struct fb_info *info) { struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb); + switch (blank) { case FB_BLANK_NORMAL: writel(1, fb->reg_base + FB_SET_BLANK);