get-versions: fix typo in fsverity.ver
diff mbox

Message ID 1528719237-1278-1-git-send-email-amir73il@gmail.com
State New
Headers show

Commit Message

Amir Goldstein June 11, 2018, 12:13 p.m. UTC
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Hi Ted,

BTW, why are fsverity and ima-evm-utils required and not
optional repos?

Thanks,
Amir.

 get-versions | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Theodore Y. Ts'o June 12, 2018, 1:41 a.m. UTC | #1
On Mon, Jun 11, 2018 at 03:13:57PM +0300, Amir Goldstein wrote:
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

Applied, thanks.

> BTW, why are fsverity and ima-evm-utils required and not
> optional repos?

My general rule of thumb has been to include everything needed for
xfstests on kvm-xfstests and gce-xfstest, but not things needed for
android-xfstests.

The fsverity and ima-evm-utils git repos don't technically meet that
definition yet, but there are patches for tests for fsverity that
would require fsverity.  I've been investigating ways of allow IMA to
use fsverity, so that's why I had included it, but it's certainly much
more of a pre-emptive inclusion compared to fsverity.

Part of it is that adding optional repos means I have to test the
build and test appliance generation with and without the repo, so it's
a tiny bit more work/complexity, and I decided to be lazy / keep
things simple.

If the inclusion of ima-evm-utils is annoying, we could look at making
it be optional.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/get-versions b/get-versions
index 9cbecd0..7058212 100755
--- a/get-versions
+++ b/get-versions
@@ -25,7 +25,7 @@  fi
 if test -d fsverity
 then
     cd fsverity
-    ver=$(git describe --always --dirty); echo "fsverity	$ver ($(git log -1 --pretty=%cD))" > ../$TMPDIR/keyutils.ver
+    ver=$(git describe --always --dirty); echo "fsverity	$ver ($(git log -1 --pretty=%cD))" > ../$TMPDIR/fsverity.ver
     cd ..
 fi