| Message ID | 20180612232348.27979-1-shuah@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Thanks, Shuah! Tom On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote: > sparc64 test fails with the following errors on non-sparc64 systems. Fix > the Makefile to do nothing on non-sparc64 systems to suppress the errors: > > make run_tests > adi-test.c: Assembler messages: > adi-test.c:302: Error: no such instruction: `rd %tick,%r13' > adi-test.c:304: Error: no such instruction: `rd %tick,%rbp' > adi-test.c:190: Error: no such instruction: `rd %tick,%rbp' > adi-test.c:192: Error: no such instruction: `rd %tick,%rdx' > adi-test.c:273: Error: no such instruction: `rd %tick,%rbx' > adi-test.c:276: Error: no such instruction: `rd %tick,%rdx' > adi-test.c:217: Error: no such instruction: `rd %tick,%rbp' > adi-test.c:220: Error: no such instruction: `rd %tick,%rdx' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:246: Error: no such instruction: `rd %tick,%rbp' > adi-test.c:248: Error: no such instruction: `rd %tick,%rdx' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > adi-test.c:79: Error: no such instruction: `rd %tick,%rax' > <builtin>: recipe for target 'adi-test' failed > make[1]: *** [adi-test] Error 1 > adi: [FAIL] > ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found > ../lib.mk:73: recipe for target 'run_tests' failed > make: *** [run_tests] Error 1 > > Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/13/2018 11:20 AM, Tom Hromatka wrote: > Thanks, Shuah! > > Tom > > > On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote: >> sparc64 test fails with the following errors on non-sparc64 systems. Fix >> the Makefile to do nothing on non-sparc64 systems to suppress the errors: >> >> make run_tests >> adi-test.c: Assembler messages: >> adi-test.c:302: Error: no such instruction: `rd %tick,%r13' >> adi-test.c:304: Error: no such instruction: `rd %tick,%rbp' >> adi-test.c:190: Error: no such instruction: `rd %tick,%rbp' >> adi-test.c:192: Error: no such instruction: `rd %tick,%rdx' >> adi-test.c:273: Error: no such instruction: `rd %tick,%rbx' >> adi-test.c:276: Error: no such instruction: `rd %tick,%rdx' >> adi-test.c:217: Error: no such instruction: `rd %tick,%rbp' >> adi-test.c:220: Error: no such instruction: `rd %tick,%rdx' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:246: Error: no such instruction: `rd %tick,%rbp' >> adi-test.c:248: Error: no such instruction: `rd %tick,%rdx' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >> <builtin>: recipe for target 'adi-test' failed >> make[1]: *** [adi-test] Error 1 >> adi: [FAIL] >> ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found >> ../lib.mk:73: recipe for target 'run_tests' failed >> make: *** [run_tests] Error 1 >> >> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> > > Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> > Hi Dave, get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? It would be good to get this in for 4.18-rc2 If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Shuah Khan <shuah@kernel.org> Date: Fri, 15 Jun 2018 10:33:21 -0600 > On 06/13/2018 11:20 AM, Tom Hromatka wrote: >> Thanks, Shuah! >> >> Tom >> >> >> On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote: >>> sparc64 test fails with the following errors on non-sparc64 systems. Fix >>> the Makefile to do nothing on non-sparc64 systems to suppress the errors: >>> >>> make run_tests >>> adi-test.c: Assembler messages: >>> adi-test.c:302: Error: no such instruction: `rd %tick,%r13' >>> adi-test.c:304: Error: no such instruction: `rd %tick,%rbp' >>> adi-test.c:190: Error: no such instruction: `rd %tick,%rbp' >>> adi-test.c:192: Error: no such instruction: `rd %tick,%rdx' >>> adi-test.c:273: Error: no such instruction: `rd %tick,%rbx' >>> adi-test.c:276: Error: no such instruction: `rd %tick,%rdx' >>> adi-test.c:217: Error: no such instruction: `rd %tick,%rbp' >>> adi-test.c:220: Error: no such instruction: `rd %tick,%rdx' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:246: Error: no such instruction: `rd %tick,%rbp' >>> adi-test.c:248: Error: no such instruction: `rd %tick,%rdx' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>> <builtin>: recipe for target 'adi-test' failed >>> make[1]: *** [adi-test] Error 1 >>> adi: [FAIL] >>> ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found >>> ../lib.mk:73: recipe for target 'run_tests' failed >>> make: *** [run_tests] Error 1 >>> >>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> >> >> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> >> > > get_maintainers didn't include your name for this patch. Would you like to > take this fix through sparc tree? It would be good to get this in for > 4.18-rc2 > > If so, please let me know if you would like me to resend the patch > with Tom's Reviewed-by tag. I'm very busy, so this time could you merge this for me? Thanks! Acked-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/15/2018 10:41 AM, David Miller wrote: > From: Shuah Khan <shuah@kernel.org> > Date: Fri, 15 Jun 2018 10:33:21 -0600 > >> On 06/13/2018 11:20 AM, Tom Hromatka wrote: >>> Thanks, Shuah! >>> >>> Tom >>> >>> >>> On 06/12/2018 05:23 PM, Shuah Khan (Samsung OSG) wrote: >>>> sparc64 test fails with the following errors on non-sparc64 systems. Fix >>>> the Makefile to do nothing on non-sparc64 systems to suppress the errors: >>>> >>>> make run_tests >>>> adi-test.c: Assembler messages: >>>> adi-test.c:302: Error: no such instruction: `rd %tick,%r13' >>>> adi-test.c:304: Error: no such instruction: `rd %tick,%rbp' >>>> adi-test.c:190: Error: no such instruction: `rd %tick,%rbp' >>>> adi-test.c:192: Error: no such instruction: `rd %tick,%rdx' >>>> adi-test.c:273: Error: no such instruction: `rd %tick,%rbx' >>>> adi-test.c:276: Error: no such instruction: `rd %tick,%rdx' >>>> adi-test.c:217: Error: no such instruction: `rd %tick,%rbp' >>>> adi-test.c:220: Error: no such instruction: `rd %tick,%rdx' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:246: Error: no such instruction: `rd %tick,%rbp' >>>> adi-test.c:248: Error: no such instruction: `rd %tick,%rdx' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> adi-test.c:79: Error: no such instruction: `rd %tick,%rax' >>>> <builtin>: recipe for target 'adi-test' failed >>>> make[1]: *** [adi-test] Error 1 >>>> adi: [FAIL] >>>> ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found >>>> ../lib.mk:73: recipe for target 'run_tests' failed >>>> make: *** [run_tests] Error 1 >>>> >>>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> >>> >>> Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com> >>> >> >> get_maintainers didn't include your name for this patch. Would you like to >> take this fix through sparc tree? It would be good to get this in for >> 4.18-rc2 >> >> If so, please let me know if you would like me to resend the patch >> with Tom's Reviewed-by tag. > > I'm very busy, so this time could you merge this for me? Thanks! > > Acked-by: David S. Miller <davem@davemloft.net> > Okay. I will take care of this. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/testing/selftests/sparc64/Makefile b/tools/testing/selftests/sparc64/Makefile index 2082eeffd779..442f0ca45441 100644 --- a/tools/testing/selftests/sparc64/Makefile +++ b/tools/testing/selftests/sparc64/Makefile @@ -1,7 +1,17 @@ +uname_M := $(shell uname -m 2>/dev/null || echo not) +ARCH ?= $(shell echo $(uname_M) | sed -e s/x86_64/x86/) + +ifneq ($(ARCH),sparc64) +nothing: +.PHONY: all clean run_tests install +.SILENT: +else + SUBDIRS := drivers TEST_PROGS := run.sh + .PHONY: all clean include ../lib.mk @@ -44,3 +54,4 @@ override define CLEAN make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ done endef +endif
sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors: make run_tests adi-test.c: Assembler messages: adi-test.c:302: Error: no such instruction: `rd %tick,%r13' adi-test.c:304: Error: no such instruction: `rd %tick,%rbp' adi-test.c:190: Error: no such instruction: `rd %tick,%rbp' adi-test.c:192: Error: no such instruction: `rd %tick,%rdx' adi-test.c:273: Error: no such instruction: `rd %tick,%rbx' adi-test.c:276: Error: no such instruction: `rd %tick,%rdx' adi-test.c:217: Error: no such instruction: `rd %tick,%rbp' adi-test.c:220: Error: no such instruction: `rd %tick,%rdx' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:246: Error: no such instruction: `rd %tick,%rbp' adi-test.c:248: Error: no such instruction: `rd %tick,%rdx' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1 adi: [FAIL] ./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed make: *** [run_tests] Error 1 Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> --- tools/testing/selftests/sparc64/Makefile | 11 +++++++++++ 1 file changed, 11 insertions(+)