From patchwork Fri Jun 15 18:23:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Lingshan X-Patchwork-Id: 10467279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23C7360532 for ; Fri, 15 Jun 2018 18:25:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 146B428E3B for ; Fri, 15 Jun 2018 18:25:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0939528E40; Fri, 15 Jun 2018 18:25:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A92F28E3B for ; Fri, 15 Jun 2018 18:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756502AbeFOSY7 (ORCPT ); Fri, 15 Jun 2018 14:24:59 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:47598 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756497AbeFOSY7 (ORCPT ); Fri, 15 Jun 2018 14:24:59 -0400 Received: from vstart.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Fri, 15 Jun 2018 12:24:49 -0600 From: Zhu Lingshan To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, nab@linux-iscsi.org, mchristi@redhat.com, martin.petersen@oracle.com Cc: hare@suse.de, lduncan@suse.com, ddiss@suse.de, lszhu@suse.de, Zhu Lingshan Subject: [PATCH 16/33] TCMU PR: init PR info when empty for TCMU dev Date: Sat, 16 Jun 2018 02:23:25 +0800 Message-Id: <20180615182342.6239-16-lszhu@suse.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180615182342.6239-1-lszhu@suse.com> References: <20180615182342.6239-1-lszhu@suse.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When try to register an IT_Nexus, if tcmu_pr_info_get() returns -ENODATA, this means the string stored on the TCMU DEVICE records(for example, RBD metadata) which represent Persistent Reservation information is empty,there are no registrations, we should initialize a new struct tcmu_pr_info. This patch added a function tcmu_pr_info_init() to initialize Persistent Reservation struct tcmu_pr_info, encode it to a string, and store this string in the TCMU device records. Signed-off-by: Zhu Lingshan --- drivers/target/target_core_user.c | 48 +++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 957e444d853b..8d860b59d277 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -2437,6 +2437,54 @@ static int tcmu_pr_info_encode(struct tcmu_pr_info *pr_info, return rc; } +static int tcmu_pr_info_init(struct tcmu_dev *udev, + struct tcmu_pr_info **_pr_info, + char **_pr_xattr, int *_pr_xattr_len) +{ + struct tcmu_pr_info *pr_info; + char *pr_xattr = NULL; + int pr_xattr_len = 0; + int rc; + + pr_info = kzalloc(sizeof(*pr_info), GFP_KERNEL); + if (!pr_info) + return -ENOMEM; + + pr_info->vers = TCMU_PR_INFO_XATTR_VERS; + INIT_LIST_HEAD(&pr_info->regs); + pr_info->seq = 1; + + rc = tcmu_pr_info_encode(pr_info, &pr_xattr, &pr_xattr_len); + if (rc) { + pr_err("failed to encode PR xattr: %d\n", rc); + goto err_info_free; + } + + rc = tcmu_set_dev_pr_info(udev, pr_xattr); + if (rc) { + pr_err("failed to set PR xattr: %d\n", rc); + goto err_xattr_free; + } + + *_pr_info = pr_info; + if (_pr_xattr) { + WARN_ON(!_pr_xattr_len); + *_pr_xattr = pr_xattr; + *_pr_xattr_len = pr_xattr_len; + } else { + kfree(pr_xattr); + } + pr_debug("successfully initialized PR info\n"); + + return 0; + +err_xattr_free: + kfree(pr_xattr); +err_info_free: + kfree(pr_info); + return rc; +} + static int tcmu_configure_device(struct se_device *dev) { struct tcmu_dev *udev = TCMU_DEV(dev);