| Message ID | 20180617103736.1162-1-youling257@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Thank you for this patch. Please rebase this patch on top of: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy Where the entries have been sorted alphabetically and the file has been renamed to touchscreen_dmi.c On 17-06-18 12:37, youling257 wrote: > Signed-off-by: youling257 <youling257@gmail.com> > --- > drivers/platform/x86/silead_dmi.c | 35 +++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 853a7ce4601c..9e61182c8aff 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -326,6 +326,23 @@ static const struct silead_ts_dmi_data onda_v891w_v1_data = { > .properties = onda_v891w_v1_props, > }; > > +static const struct property_entry onda_v891w_v3_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-min-x", 35), > + PROPERTY_ENTRY_U32("touchscreen-min-y", 15), > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1625), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1135), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_STRING("firmware-name", "FW_I89_GSL3676B_19201200_.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct silead_ts_dmi_data onda_v891w_v3_data = { > + .acpi_name = "MSSL1680:00", > + .properties = onda_v891w_v3_props, > +}; > + > static const struct dmi_system_id silead_ts_dmi_table[] = { > { > /* CUBE iwork8 Air */ > @@ -554,6 +571,24 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"), > }, > }, > + { > + /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */ > + .driver_data = (void *)&onda_v891w_v3_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), > + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"), > + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"), > + }, > + }, This entry is using the V1 BIOS data, so it needs to be dropped. I know some V3 tablets ship with the V1 BIOS, I plan to add the possibility to directly select a set of ts_dmi_data from the kernel commandline. This will also be useful to select the right data for the many rebrands of various tablets with a Silead touchscreen. Regards, Hans > + { > + /* ONDA V891w P891WBECV3A02121 32GB */ > + .driver_data = (void *)&onda_v891w_v3_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), > + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"), > + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"), > + }, > + }, > { }, > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index 853a7ce4601c..9e61182c8aff 100644 --- a/drivers/platform/x86/silead_dmi.c +++ b/drivers/platform/x86/silead_dmi.c @@ -326,6 +326,23 @@ static const struct silead_ts_dmi_data onda_v891w_v1_data = { .properties = onda_v891w_v1_props, }; +static const struct property_entry onda_v891w_v3_props[] = { + PROPERTY_ENTRY_U32("touchscreen-min-x", 35), + PROPERTY_ENTRY_U32("touchscreen-min-y", 15), + PROPERTY_ENTRY_U32("touchscreen-size-x", 1625), + PROPERTY_ENTRY_U32("touchscreen-size-y", 1135), + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), + PROPERTY_ENTRY_STRING("firmware-name", "FW_I89_GSL3676B_19201200_.fw"), + PROPERTY_ENTRY_U32("silead,max-fingers", 10), + PROPERTY_ENTRY_BOOL("silead,home-button"), + { } +}; + +static const struct silead_ts_dmi_data onda_v891w_v3_data = { + .acpi_name = "MSSL1680:00", + .properties = onda_v891w_v3_props, +}; + static const struct dmi_system_id silead_ts_dmi_table[] = { { /* CUBE iwork8 Air */ @@ -554,6 +571,24 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"), }, }, + { + /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */ + .driver_data = (void *)&onda_v891w_v3_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"), + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"), + }, + }, + { + /* ONDA V891w P891WBECV3A02121 32GB */ + .driver_data = (void *)&onda_v891w_v3_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"), + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"), + }, + }, { }, };
Signed-off-by: youling257 <youling257@gmail.com> --- drivers/platform/x86/silead_dmi.c | 35 +++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)